From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA428C432C3 for ; Fri, 15 Nov 2019 22:53:38 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9080820733; Fri, 15 Nov 2019 22:53:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Tq01I3j5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="hc8Tse/F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9080820733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iVkTB-0005wB-8u; Fri, 15 Nov 2019 22:53:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iVkT6-0005vw-B6 for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Nov 2019 22:53:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=USXIIyVD4MMVAJc7YV54cJ3jWMgCEG2uBHFD4uFoLrE=; b=Tq01I3j59LudmNJLl3lakvmatr sQ8I2X5dDiqNj7cDolpiC3QeQXpBVs8v2SJzELk8K+5aplL/1d6D8+l33GC/HYdt28vXV/w6wjxob OKyN4QqgWvLb2hI9kri+2FKQZiHwgwCSvQfXvSkP7C8JGMcLmNRHI8sSf5LIZKmY26GY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=USXIIyVD4MMVAJc7YV54cJ3jWMgCEG2uBHFD4uFoLrE=; b=hc8Tse/FgS4xu0miOH+x2EHxFW +eIiDhj9Ui0WIHplv8yExfSddlXHLGnYn0Lf2MzZnPLJzRKODmYwsr6C4t7qQlOGhc/Hpg2yuW/tK Bokc3l1AP2QGD0X39ng9ruWZ695F8fHisfNSm7V4TgX9JPlz7oBDe/3rJI49hQX1qtpE=; Received: from mga11.intel.com ([192.55.52.93]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iVkT4-006CA3-ML for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Nov 2019 22:53:32 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 14:53:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,309,1569308400"; d="scan'208";a="230598878" Received: from bpgilles-mobl1.ger.corp.intel.com (HELO localhost) ([10.251.95.141]) by fmsmga004.fm.intel.com with ESMTP; 15 Nov 2019 14:53:20 -0800 Date: Sat, 16 Nov 2019 00:53:19 +0200 From: Jarkko Sakkinen To: Eric Biggers Message-ID: <20191115225319.GB29389@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115192227.GA150987@sol.localdomain> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iVkT4-006CA3-ML Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Howells , "Theodore Y . Ts'o" , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Paul Lawrence , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Nov 15, 2019 at 11:22:27AM -0800, Eric Biggers wrote: > On Fri, Nov 15, 2019 at 07:28:53PM +0200, Jarkko Sakkinen wrote: > > > > I don't see anything obviously wrong. Just would reformat it a bit. > > How you tested it? > > > > I'm not sure all the blank lines you're suggesting would be an improvement. > The ones in fscrypt_provisioning_key_preparse() might make sense though. OK. Some of this aesthics comes from the feedback that I've received during Intel SGX patch set review process (of course subsystem is different i.e. x86). I tend to agree at least that before a new conditional statement it is more readable if there is a blank line before it. > I'm working on an xfstest for this: > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > It's not quite ready, though. I'll post it for review when it is. > > Someone is also planning to update Android userspace to use this. So if there > are any issues from that, I'll hear about it. Cool. Can you combine this patch and matching test (once it is done) to a patch set? /Jarkko _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel