From: "Javier González" <javier@javigon.com>
To: jaegeuk@kernel.org, yuchao0@huawei.com
Cc: "Javier González" <javier.gonz@samsung.com>,
damien.lemoal@wdc.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs: disble physical prealloc in LSF mount
Date: Fri, 22 Nov 2019 09:59:52 +0100 [thread overview]
Message-ID: <20191122085952.12754-1-javier@javigon.com> (raw)
From: Javier González <javier.gonz@samsung.com>
Fix file system corruption when using LFS mount (e.g., in zoned
devices). Seems like the fallback into buffered I/O creates an
inconsistency if the application is assuming both read and write DIO. I
can easily reproduce a corruption with a simple RocksDB test.
Might be that the f2fs_forced_buffered_io path brings some problems too,
but I have not seen other failures besides this one.
Problem reproducible without a zoned block device, simply by forcing
LFS mount:
$ sudo mkfs.f2fs -f -m /dev/nvme0n1
$ sudo mount /dev/nvme0n1 /mnt/f2fs
$ sudo /opt/rocksdb/db_bench --benchmarks=fillseq --use_existing_db=0
--use_direct_reads=true --use_direct_io_for_flush_and_compaction=true
--db=/mnt/f2fs --num=5000 --value_size=1048576 --verify_checksum=1
--block_size=65536
Note that the options that cause the problem are:
--use_direct_reads=true --use_direct_io_for_flush_and_compaction=true
Fixes: f9d6d0597698 ("f2fs: fix out-place-update DIO write")
Signed-off-by: Javier González <javier.gonz@samsung.com>
---
fs/f2fs/data.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5755e897a5f0..b045dd6ab632 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1081,9 +1081,6 @@ int f2fs_preallocate_blocks(struct kiocb *iocb, struct iov_iter *from)
return err;
}
- if (direct_io && allow_outplace_dio(inode, iocb, from))
- return 0;
-
if (is_inode_flag_set(inode, FI_NO_PREALLOC))
return 0;
--
2.17.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2019-11-22 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 8:59 Javier González [this message]
2019-11-25 0:48 ` [f2fs-dev] [PATCH] f2fs: disble physical prealloc in LSF mount Damien Le Moal
2019-11-25 19:03 ` Javier González
2019-11-26 2:06 ` Damien Le Moal
2019-11-26 3:57 ` Javier González
2019-11-26 6:19 ` Damien Le Moal
2019-11-26 6:20 ` Damien Le Moal
2019-11-26 6:43 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122085952.12754-1-javier@javigon.com \
--to=javier@javigon.com \
--cc=damien.lemoal@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=javier.gonz@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).