From: Christoph Hellwig <hch@infradead.org>
To: ira.weiny@intel.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
Josef Bacik <josef@toxicpanda.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-f2fs-devel@lists.sourceforge.net,
Trond Myklebust <trond.myklebust@hammerspace.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH V3 2/3] fs: Move swap_[de]activate to file_operations
Date: Mon, 2 Dec 2019 09:01:53 -0800 [thread overview]
Message-ID: <20191202170153.GA2870@infradead.org> (raw)
In-Reply-To: <20191129163300.14749-3-ira.weiny@intel.com>
While the patch itself looks fine, I kinda disagree with the rationale.
If we want different ops for DAX that applies to file operations just
as much as to the address space operations.
However I agree that the ops are logically a better fit for the file
operations, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-12-02 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 16:32 [f2fs-dev] [PATCH V3 0/3] Move swap functions out of address space operations ira.weiny
2019-11-29 16:32 ` [f2fs-dev] [PATCH V3 1/3] fs: Clean up mapping variable ira.weiny
2019-11-29 16:32 ` [f2fs-dev] [PATCH V3 2/3] fs: Move swap_[de]activate to file_operations ira.weiny
2019-12-02 17:01 ` Christoph Hellwig [this message]
2019-11-29 16:33 ` [f2fs-dev] [PATCH V3 3/3] Documentation/fs: Move swap_[de]activate() " ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202170153.GA2870@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).