From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F66C43603 for ; Thu, 5 Dec 2019 07:07:24 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E2EB2245C; Thu, 5 Dec 2019 07:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="ereos++X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="SuuVr3sN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ttZfZk2N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E2EB2245C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iclER-0004bu-JC; Thu, 05 Dec 2019 07:07:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iclEM-0004bI-Lp for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Dec 2019 07:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LMxh8PsOTdp3uRQncunavdBObTQIFTMPychpOdLcPaI=; b=ereos++XF2VsIhbW+ekPg0ebmQ ZuWzyRmrtzq8SZE0sh60Rk4omgofiGgjyO8RlCdyGPzu8naL2qjJb6CjpRIQkAR5NfZxbNc0uM9OA 6xnoDGY8x7p/0tUVOnXD2ojNfA6PXGzN7O0SYxqqZWBMS+Bek8WQ+pN2+xYYHui5o3xA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LMxh8PsOTdp3uRQncunavdBObTQIFTMPychpOdLcPaI=; b=SuuVr3sNpVH2O+pWGwZ2rwKEYi gFOD749KhjB9Ow8NuAQo4AHBZ6jC6L5F8ILbyu5oF73Ust72WqBX8rc9yoKRYMs1b0gbUo8YfRzv6 gGEbaNMlIFLs5gkdNnJtZFPfGJ67oJY5Ggoo1RF3h+qnqz+Q7ibvU7huw1IMb0sbksK8=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iclEK-00ANf9-NN for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Dec 2019 07:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LMxh8PsOTdp3uRQncunavdBObTQIFTMPychpOdLcPaI=; b=ttZfZk2NbSMy0oKG8mJmZ66Jj Fr2AaQPAQqEz8B84HALo6GcQCEvz6v2yxXag6Gy/NeuZOLwkz+gBEp23dDd+yR/qVEhJkP7Lj27Lk MfvFttoe/KNP8O0pMCqzioRjX9qHDS+PsLyRnO/1CMlsDkfPDZ3cZ1r1u3Wcy/ZDQT/RuLvQVGG4K UXQjHkpQNLXt+eg6Qj+SoFYbHmN17I6l+YXFi8nW0sipytrDTPPGYLilIqMGTyuHHSh2Wsb58lDEc yVX5I2tHXwNjpjfCJiA8HUoWnTAmyfb+Zbo4MaWO0emJolsCELJj6F6bvRQafPqYCOHC/9e6BgqFR 24GFHE76Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iclDq-0008IY-St; Thu, 05 Dec 2019 07:06:46 +0000 Date: Wed, 4 Dec 2019 23:06:46 -0800 From: Matthew Wilcox To: Tiezhu Yang Message-ID: <20191205070646.GA29612@bombadil.infradead.org> References: <1575377810-3574-1-git-send-email-yangtiezhu@loongson.cn> <20191203135651.GU20752@bombadil.infradead.org> <0003a252-b003-0a8c-b4ac-6280557ece06@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0003a252-b003-0a8c-b4ac-6280557ece06@loongson.cn> User-Agent: Mutt/1.12.1 (2019-06-15) X-Headers-End: 1iclEK-00ANf9-NN Subject: Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ecryptfs@vger.kernel.org, "Theodore Y. Ts'o" , linux-kernel@vger.kernel.org, Tyler Hicks , Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Dec 05, 2019 at 08:56:07AM +0800, Tiezhu Yang wrote: > > And, as I asked twice in the last round of review, did you benchmark > > this change? > > Before sending this v2 patch, I have done the test used with your test > program and already pointed out the following implementation is better: I didn't mean "have you run the test program i wrote". I meant "have you booted a kernel with this change and done some performance measurements to see if you've changed anything". _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel