From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] fs-verity: use mempool for hash requests
Date: Tue, 14 Jan 2020 13:32:39 -0800 [thread overview]
Message-ID: <20200114213239.GI41220@gmail.com> (raw)
In-Reply-To: <20191231175545.20709-1-ebiggers@kernel.org>
On Tue, Dec 31, 2019 at 11:55:45AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When initializing an fs-verity hash algorithm, also initialize a mempool
> that contains a single preallocated hash request object. Then replace
> the direct calls to ahash_request_alloc() and ahash_request_free() with
> allocating and freeing from this mempool.
>
> This eliminates the possibility of the allocation failing, which is
> desirable for the I/O path.
>
> This doesn't cause deadlocks because there's no case where multiple hash
> requests are needed at a time to make forward progress.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/verity/enable.c | 8 +--
> fs/verity/fsverity_private.h | 16 ++++--
> fs/verity/hash_algs.c | 98 +++++++++++++++++++++++++++---------
> fs/verity/open.c | 4 +-
> fs/verity/verify.c | 17 +++----
> 5 files changed, 97 insertions(+), 46 deletions(-)
>
Applied to fscrypt.git#fsverity for 5.6.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-01-14 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 17:55 [f2fs-dev] [PATCH] fs-verity: use mempool for hash requests Eric Biggers
2020-01-14 0:28 ` Theodore Y. Ts'o
2020-01-14 21:32 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114213239.GI41220@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).