Linux-f2fs-devel Archive on
 help / color / Atom feed
From: "Darrick J. Wong" <>
To: Christoph Hellwig <>
Cc: Jan Kara <>, Adrian Hunter <>,
	Chris Mason <>,
	Andreas Dilger <>,
	Andreas Gruenbacher <>,
	Sage Weil <>, Richard Weinberger <>,
	YueHaibing <>,
	Ilya Dryomov <>,, Arnd Bergmann <>,
	Josef Bacik <>,
	Alexander Viro <>,
	David Sterba <>, Jaegeuk Kim <>,, Theodore Ts'o <>,
	Artem Bityutskiy <>,
	Jeff Layton <>,,,,,,
	Linus Torvalds <>,
Subject: Re: [f2fs-dev] [PATCH v4] fs: Fix page_mkwrite off-by-one errors
Date: Wed, 15 Jan 2020 09:10:47 -0800
Message-ID: <20200115171047.GA8247@magnolia> (raw)
In-Reply-To: <>

On Wed, Jan 08, 2020 at 08:57:10AM -0800, Christoph Hellwig wrote:
> I don't want to be the party pooper, but shouldn't this be a series
> with one patch to add the helper, and then once for each fs / piece
> of common code switched over?

The current patch in the iomap branch contains the chunks that add the
helper function, fix iomap, and whatever chunks for other filesystems
that don't cause /any/ merge complaints in for-next.  That means btrfs,
ceph, ext4, and ubifs will get fixed this time around.

Seeing as it's been floating around in for-next for a week now I'd
rather not rebase the branch just to rip out the four parts that haven't
given me any headaches so that they can be applied separately. :)

The acks from the other fs maintainers were very helpful, but at the
same time, I don't want to become a shadow vfs maintainer.

Therefore, whatever's in this v4 patch that isn't in [1] will have to be
sent separately.


> On Wed, Jan 08, 2020 at 02:15:28PM +0100, Andreas Gruenbacher wrote:
> > Hi Darrick,
> > 
> > here's an updated version with the latest feedback incorporated.  Hope
> > you find that useful.
> > 
> > As far as the f2fs merge conflict goes, I've been told by Linus not to
> > resolve those kinds of conflicts but to point them out when sending the
> > merge request.  So this shouldn't be a big deal.
> Also this isn't really the proper way to write a commit message.  This
> text would go into the cover letter if it was a series..

<urk> Yeah.


Linux-f2fs-devel mailing list

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 13:15 Andreas Gruenbacher
2020-01-08 16:57 ` Christoph Hellwig
2020-01-15 17:10   ` Darrick J. Wong [this message]
2020-01-08 22:42 ` Jaegeuk Kim
2020-01-09 13:34 ` Jeff Layton

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200115171047.GA8247@magnolia \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-f2fs-devel Archive on

Archives are clonable:
	git clone --mirror linux-f2fs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-f2fs-devel linux-f2fs-devel/ \
	public-inbox-index linux-f2fs-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone