* [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static
@ 2020-01-15 1:54 Zhang Xiaoxu
2020-01-15 9:59 ` Chao Yu
2020-01-15 21:40 ` Jaegeuk Kim
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Xiaoxu @ 2020-01-15 1:54 UTC (permalink / raw)
To: jaegeuk, chao, zhangxiaoxu5; +Cc: linux-f2fs-devel
Fix sparse warning:
fs/f2fs/data.c:187:6: warning:
symbol 'f2fs_verify_pages' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 2576d7dd047d..b27b72107911 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -184,7 +184,7 @@ static void f2fs_decompress_work(struct bio_post_read_ctx *ctx)
}
#ifdef CONFIG_F2FS_FS_COMPRESSION
-void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
+static void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
{
f2fs_decompress_end_io(rpages, cluster_size, false, true);
}
--
2.17.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static
2020-01-15 1:54 [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static Zhang Xiaoxu
@ 2020-01-15 9:59 ` Chao Yu
2020-01-15 21:40 ` Jaegeuk Kim
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2020-01-15 9:59 UTC (permalink / raw)
To: Zhang Xiaoxu, jaegeuk, chao; +Cc: linux-f2fs-devel
Hi Xiaoxu,
On 2020/1/15 9:54, Zhang Xiaoxu wrote:
> Fix sparse warning:
>
> fs/f2fs/data.c:187:6: warning:
> symbol 'f2fs_verify_pages' was not declared. Should it be static?
Thanks for your patch.
It will be better to merge this patch into original patch which is
still on dev status, let us know if you have any other concern. :)
Thanks,
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> fs/f2fs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 2576d7dd047d..b27b72107911 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -184,7 +184,7 @@ static void f2fs_decompress_work(struct bio_post_read_ctx *ctx)
> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION
> -void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> +static void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> {
> f2fs_decompress_end_io(rpages, cluster_size, false, true);
> }
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static
2020-01-15 1:54 [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static Zhang Xiaoxu
2020-01-15 9:59 ` Chao Yu
@ 2020-01-15 21:40 ` Jaegeuk Kim
1 sibling, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2020-01-15 21:40 UTC (permalink / raw)
To: Zhang Xiaoxu; +Cc: linux-f2fs-devel
Hi,
I applied this in the original patch.
Thanks,
On 01/15, Zhang Xiaoxu wrote:
> Fix sparse warning:
>
> fs/f2fs/data.c:187:6: warning:
> symbol 'f2fs_verify_pages' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> fs/f2fs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 2576d7dd047d..b27b72107911 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -184,7 +184,7 @@ static void f2fs_decompress_work(struct bio_post_read_ctx *ctx)
> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION
> -void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> +static void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> {
> f2fs_decompress_end_io(rpages, cluster_size, false, true);
> }
> --
> 2.17.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-15 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 1:54 [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static Zhang Xiaoxu
2020-01-15 9:59 ` Chao Yu
2020-01-15 21:40 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).