From: Greg KH <gregkh@linuxfoundation.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Eric Biggers <ebiggers@kernel.org>,
Barani Muthukumaran <bmuthuku@codeaurora.org>,
Gaurav Kashyap <gaurkash@codeaurora.org>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature
Date: Fri, 17 Jan 2020 17:56:24 +0100 [thread overview]
Message-ID: <20200117165624.GC1937954@kroah.com> (raw)
In-Reply-To: <20200117164054.GD448999@mit.edu>
On Fri, Jan 17, 2020 at 11:40:54AM -0500, Theodore Y. Ts'o wrote:
> On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
> > On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > Reserve flags for the hardware-wrapped keys feature which is being
> > > worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
> > > encryption policy needs a hardware-wrapped key to be unlocked.
> > > FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
> > > a hardware-wrapped key.
> > >
> > > This reservation is tentative, and these codepoints may be reused if the
> > > feature is not upstreamed.
> >
> > NAK. While the feature itself sounds really useful we don't just
> > reserve format bits for code not upstream.
>
> I disagree; saving a codepoint to avoid accidental collision of a
> feature bit is a good and proper thing to do.
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
What kind of "deadline" do you have for that feature to then be merged?
I'm with Christoph here, we shouldn't be reserving bits for stuff not
in mergable state, what's the rush?
thansk,
greg k-h
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-01-17 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 19:20 [f2fs-dev] [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature Eric Biggers
2020-01-17 8:12 ` Christoph Hellwig
2020-01-17 16:40 ` Theodore Y. Ts'o
2020-01-17 16:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117165624.GC1937954@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bmuthuku@codeaurora.org \
--cc=ebiggers@kernel.org \
--cc=gaurkash@codeaurora.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).