From: Matthew Wilcox <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-mm@kvack.org, ocfs2-devel@oss.oracle.com,
linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead
Date: Fri, 14 Feb 2020 11:50:46 -0800 [thread overview]
Message-ID: <20200214195046.GC7778@bombadil.infradead.org> (raw)
In-Reply-To: <20200211010348.6872-2-willy@infradead.org>
On Mon, Feb 10, 2020 at 05:03:36PM -0800, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> ra_submit() which is a wrapper around __do_page_cache_readahead() already
> returns an unsigned long, and the 'nr_to_read' parameter is an unsigned
> long, so fix __do_page_cache_readahead() to return an unsigned long,
> even though I'm pretty sure we're not going to readahead more than 2^32
> pages ever.
I was going through this and realised it's completely pointless -- the
returned value from ra_submit() and __do_page_cache_readahead() is
eventually ignored through all paths. So I'm replacing this patch with
one that makes everything return void.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-02-14 19:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 1:03 [f2fs-dev] [PATCH v5 00/13] Change readahead API Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead Matthew Wilcox
2020-02-11 8:19 ` Johannes Thumshirn
2020-02-11 12:34 ` Matthew Wilcox
2020-02-12 18:13 ` Christoph Hellwig
2020-02-14 3:19 ` John Hubbard
2020-02-14 4:21 ` Matthew Wilcox
2020-02-14 4:33 ` John Hubbard
2020-02-14 19:50 ` Matthew Wilcox [this message]
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 02/13] mm: Ignore return value of ->readpages Matthew Wilcox
2020-02-12 18:13 ` Christoph Hellwig
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 03/13] mm: Put readahead pages in cache earlier Matthew Wilcox
2020-02-14 3:36 ` John Hubbard
2020-02-15 1:15 ` Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 04/13] mm: Add readahead address space operation Matthew Wilcox
2020-02-11 4:52 ` Dave Chinner
2020-02-11 12:54 ` Matthew Wilcox
2020-02-11 20:08 ` Dave Chinner
2020-02-12 18:18 ` Christoph Hellwig
2020-02-14 5:36 ` John Hubbard
2020-02-15 1:15 ` Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 05/13] mm: Add page_cache_readahead_limit Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 06/13] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-02-13 22:09 ` Junxiao Bi
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 07/13] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 08/13] erofs: Convert uncompressed files " Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 09/13] erofs: Convert compressed " Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 10/13] ext4: Convert " Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 11/13] f2fs: " Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 12/13] fuse: " Matthew Wilcox
2020-02-11 1:03 ` [f2fs-dev] [PATCH v5 13/13] iomap: " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214195046.GC7778@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=cluster-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).