From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0940BC34031 for ; Tue, 18 Feb 2020 23:24:37 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA9C822B48 for ; Tue, 18 Feb 2020 23:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Lk7J7FNz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="eiuA7yij"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zsp/4FRD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA9C822B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j4CEF-0001yt-LT; Tue, 18 Feb 2020 23:24:35 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4CE8-0001yQ-3O for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Feb 2020 23:24:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tIzAEJsuLi1rhHTq8tVU+ryOfNddGx9piIKavCdaTgI=; b=Lk7J7FNzaN/dT3Gj859FxnxFOi d6ENbxcK1iI7enaNdTx7rsSI+9R33cYe3BnhWSu6r2CD1t7wqovqnOC3/qUOH3H/alze/Xe+kcc81 Ph360gU8Re096vzUS6TmyCCOuOtBtGg0Tg+FxEcX7TbiM3pdkr8OQqn3dragwnht6zMc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tIzAEJsuLi1rhHTq8tVU+ryOfNddGx9piIKavCdaTgI=; b=eiuA7yij4fq9VPDa/tb+TP4hNs 7nBBOpnhRZ34QocDOJE+LpBd1vnEE28de7QpnGT9hycIZbbjfP67kiU1PS4dU+RgoiXuyQF5n2puy rdVzrtUEOypmQzqo9hc9eYBQHbYKATmhLgVxW4Aa+FaO/5jqgyZE3Z/Us/ex3wb9DG10=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1j4CE7-00H2Sg-2n for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Feb 2020 23:24:28 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B5F024655; Tue, 18 Feb 2020 23:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582068254; bh=cE1KL7ESu7HCICcE8VORkQLYSFi1c/bNZgc87tvL56Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zsp/4FRD1CWCCkP19KOIGA2baZ6zLP1vyNzO4mvzKrtGjtLqeHFRIYQeEnd2esFwO wbMHNod93deJ4d6Ail3dsW7kuEAu0Sdp0li82EdFJJEEBZHNaUbstYpaYm3H1kKvvn C3m/D9fZth1r/Hq9e3B5rjhKACO4QK2KwIjn63eU= Date: Tue, 18 Feb 2020 15:24:13 -0800 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200218232413.GA10213@google.com> References: <20200214094413.12784-1-yuchao0@huawei.com> <20200214094413.12784-3-yuchao0@huawei.com> <20200214184150.GB60913@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1j4CE7-00H2Sg-2n Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: clean up lfs/adaptive mount option X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 02/17, Chao Yu wrote: > On 2020/2/15 2:41, Jaegeuk Kim wrote: > >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > >> index 5152e9bf432b..d2d50827772c 100644 > >> --- a/fs/f2fs/f2fs.h > >> +++ b/fs/f2fs/f2fs.h > >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX]; > >> #define F2FS_MOUNT_FORCE_FG_GC 0x00004000 > >> #define F2FS_MOUNT_DATA_FLUSH 0x00008000 > >> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000 > >> -#define F2FS_MOUNT_ADAPTIVE 0x00020000 > >> -#define F2FS_MOUNT_LFS 0x00040000 > > > > I don't think we can remove this simply. > > > >> #define F2FS_MOUNT_USRQUOTA 0x00080000 > >> #define F2FS_MOUNT_GRPQUOTA 0x00100000 > >> #define F2FS_MOUNT_PRJQUOTA 0x00200000 > > You mean getting rid of this change or we need to fill F2FS_MOUNT_* hole as below: nvm. So, we can reuse the removed bits later in other features. > > #define F2FS_MOUNT_FAULT_INJECTION 0x00010000 > -#define F2FS_MOUNT_ADAPTIVE 0x00020000 > -#define F2FS_MOUNT_LFS 0x00040000 > +#define F2FS_MOUNT_USRQUOTA 0x00020000 > +#define F2FS_MOUNT_GRPQUOTA 0x00040000 > ... > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel