From: Matthew Wilcox <willy@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH v7 14/24] btrfs: Convert from readpages to readahead
Date: Thu, 20 Feb 2020 05:48:49 -0800 [thread overview]
Message-ID: <20200220134849.GV24185@bombadil.infradead.org> (raw)
In-Reply-To: <SN4PR0401MB35987D7B76007B93B1C5CE5E9B130@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Thu, Feb 20, 2020 at 09:42:19AM +0000, Johannes Thumshirn wrote:
> On 19/02/2020 22:03, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> >
> > Use the new readahead operation in btrfs. Add a
> > readahead_for_each_batch() iterator to optimise the loop in the XArray.
>
> OK I must admit I haven't followed this series closely, but what
> happened to said readahead_for_each_batch()?
>
> As far as I can see it's now:
>
> [...]
> > + while ((nr = readahead_page_batch(rac, pagepool))) {
Oops, forgot to update the changelog there. Yes, that's exactly what it
changed to. That discussion was here:
https://lore.kernel.org/linux-fsdevel/20200219144117.GP24185@bombadil.infradead.org/
... and then Christoph pointed out the iterators weren't really adding
much value at that point, so they got deleted. New changelog for
this patch:
btrfs: Convert from readpages to readahead
Implement the new readahead method in btrfs. Add a readahead_page_batch()
to optimise fetching a batch of pages at once.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-02-20 13:49 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 21:00 [f2fs-dev] [PATCH v7 00/23] Change readahead API Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 01/24] mm: Move readahead prototypes from mm.h Matthew Wilcox
2020-02-21 2:43 ` John Hubbard
2020-02-21 21:48 ` Matthew Wilcox
2020-02-22 0:15 ` John Hubbard
2020-02-24 21:32 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 02/24] mm: Return void from various readahead functions Matthew Wilcox
2020-02-24 21:33 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 03/24] mm: Ignore return value of ->readpages Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 04/24] mm: Move readahead nr_pages check into read_pages Matthew Wilcox
2020-02-21 4:24 ` John Hubbard
2020-02-24 21:34 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 05/24] mm: Use readahead_control to pass arguments Matthew Wilcox
2020-02-24 21:36 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 06/24] mm: Rename various 'offset' parameters to 'index' Matthew Wilcox
2020-02-21 2:21 ` John Hubbard
2020-02-21 3:27 ` John Hubbard
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 07/24] mm: rename readahead loop variable to 'i' Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 08/24] mm: Remove 'page_offset' from readahead loop Matthew Wilcox
2020-02-21 2:48 ` John Hubbard
2020-02-24 21:37 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 09/24] mm: Put readahead pages in cache earlier Matthew Wilcox
2020-02-21 3:19 ` John Hubbard
2020-02-21 3:43 ` Matthew Wilcox
2020-02-21 4:19 ` John Hubbard
2020-02-24 21:40 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 10/24] mm: Add readahead address space operation Matthew Wilcox
[not found] ` <5D7CE6BD-FABD-4901-AEF0-E0F10FC00EB1@nvidia.com>
2020-02-20 15:10 ` Matthew Wilcox
2020-02-21 4:30 ` John Hubbard
2020-02-24 21:41 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 11/24] mm: Move end_index check out of readahead loop Matthew Wilcox
2020-02-21 3:50 ` John Hubbard
2020-02-21 15:35 ` Matthew Wilcox
2020-02-21 19:41 ` John Hubbard
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 12/24] mm: Add page_cache_readahead_unbounded Matthew Wilcox
2020-02-24 21:53 ` [f2fs-dev] [Cluster-devel] " Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 13/24] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-02-24 21:54 ` [f2fs-dev] [Cluster-devel] " Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 14/24] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-02-20 9:42 ` Johannes Thumshirn
2020-02-20 13:48 ` Matthew Wilcox [this message]
2020-02-20 15:46 ` Christoph Hellwig
2020-02-20 15:54 ` Matthew Wilcox
2020-02-20 15:57 ` Christoph Hellwig
2020-02-24 21:43 ` Christoph Hellwig
2020-02-24 21:54 ` Matthew Wilcox
2020-02-24 21:57 ` Christoph Hellwig
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 15/24] erofs: Convert uncompressed files " Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 16/24] erofs: Convert compressed " Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 17/24] ext4: Convert " Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 18/24] ext4: Pass the inode to ext4_mpage_readpages Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 19/24] f2fs: Convert from readpages to readahead Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] [PATCH v7 20/24] fuse: " Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] [PATCH v7 21/24] iomap: Restructure iomap_readpages_actor Matthew Wilcox
2020-02-20 15:47 ` Christoph Hellwig
2020-02-20 16:24 ` Matthew Wilcox
2020-02-24 22:17 ` Christoph Hellwig
2020-02-25 1:49 ` Matthew Wilcox
2020-02-22 0:44 ` Darrick J. Wong
2020-02-22 1:54 ` Matthew Wilcox
2020-02-23 17:55 ` Darrick J. Wong
2020-02-19 21:01 ` [f2fs-dev] [PATCH v7 22/24] iomap: Convert from readpages to readahead Matthew Wilcox
2020-02-20 15:49 ` Christoph Hellwig
2020-02-20 16:57 ` Matthew Wilcox
2020-02-22 1:00 ` Darrick J. Wong
2020-02-24 4:33 ` Matthew Wilcox
2020-02-24 16:52 ` Darrick J. Wong
2020-02-22 1:03 ` Darrick J. Wong
2020-02-22 1:09 ` Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] [PATCH v7 23/24] mm: Document why we don't set PageReadahead Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] [PATCH v7 24/24] mm: Use memalloc_nofs_save in readahead path Matthew Wilcox
2020-02-20 17:54 ` [f2fs-dev] [PATCH v7 00/23] Change readahead API David Sterba
2020-02-20 22:39 ` Matthew Wilcox
2020-02-21 11:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220134849.GV24185@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=cluster-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).