* [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
@ 2020-02-29 10:49 Chao Yu
2020-03-24 6:10 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2020-02-29 10:49 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
due to f2fs_post_read_required() has did that.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/f2fs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index f4bcbbd5e9ed..882f9ad3445b 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
return true;
if (f2fs_is_multi_device(sbi))
return true;
- if (f2fs_compressed_file(inode))
- return true;
/*
* for blkzoned device, fallback direct IO to buffered IO, so
* all IOs can be serialized by log-structured write.
--
2.18.0.rc1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
2020-02-29 10:49 [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check Chao Yu
@ 2020-03-24 6:10 ` Chao Yu
2020-03-24 15:43 ` Jaegeuk Kim
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2020-03-24 6:10 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
Jaegeuk,
Missed to apply this patch?
On 2020/2/29 18:49, Chao Yu wrote:
> due to f2fs_post_read_required() has did that.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/f2fs.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index f4bcbbd5e9ed..882f9ad3445b 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> return true;
> if (f2fs_is_multi_device(sbi))
> return true;
> - if (f2fs_compressed_file(inode))
> - return true;
> /*
> * for blkzoned device, fallback direct IO to buffered IO, so
> * all IOs can be serialized by log-structured write.
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
2020-03-24 6:10 ` Chao Yu
@ 2020-03-24 15:43 ` Jaegeuk Kim
2020-03-25 1:26 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Jaegeuk Kim @ 2020-03-24 15:43 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
On 03/24, Chao Yu wrote:
> Jaegeuk,
>
> Missed to apply this patch?
>
> On 2020/2/29 18:49, Chao Yu wrote:
> > due to f2fs_post_read_required() has did that.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/f2fs.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index f4bcbbd5e9ed..882f9ad3445b 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> > return true;
> > if (f2fs_is_multi_device(sbi))
> > return true;
> > - if (f2fs_compressed_file(inode))
> > - return true;
I thought that we can keep this to avoid any confusion when porting to old
production kernel which uses ICE.
> > /*
> > * for blkzoned device, fallback direct IO to buffered IO, so
> > * all IOs can be serialized by log-structured write.
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
2020-03-24 15:43 ` Jaegeuk Kim
@ 2020-03-25 1:26 ` Chao Yu
2020-03-25 2:17 ` Jaegeuk Kim
0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2020-03-25 1:26 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-kernel, linux-f2fs-devel
On 2020/3/24 23:43, Jaegeuk Kim wrote:
> On 03/24, Chao Yu wrote:
>> Jaegeuk,
>>
>> Missed to apply this patch?
>>
>> On 2020/2/29 18:49, Chao Yu wrote:
>>> due to f2fs_post_read_required() has did that.
>>>
>>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>>> ---
>>> fs/f2fs/f2fs.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>>> index f4bcbbd5e9ed..882f9ad3445b 100644
>>> --- a/fs/f2fs/f2fs.h
>>> +++ b/fs/f2fs/f2fs.h
>>> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
>>> return true;
>>> if (f2fs_is_multi_device(sbi))
>>> return true;
>>> - if (f2fs_compressed_file(inode))
>>> - return true;
>
> I thought that we can keep this to avoid any confusion when porting to old
> production kernel which uses ICE.
That old kernel w/ ICE doesn't have f2fs_post_read_required(), right?
I thought we backport features with order of the time fsverity/compression
feature was introduced, then f2fs_post_read_required() should be there
when we backport compression feature.
Thanks,
>
>>> /*
>>> * for blkzoned device, fallback direct IO to buffered IO, so
>>> * all IOs can be serialized by log-structured write.
>>>
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
2020-03-25 1:26 ` Chao Yu
@ 2020-03-25 2:17 ` Jaegeuk Kim
2020-03-25 2:20 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Jaegeuk Kim @ 2020-03-25 2:17 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
On 03/25, Chao Yu wrote:
> On 2020/3/24 23:43, Jaegeuk Kim wrote:
> > On 03/24, Chao Yu wrote:
> >> Jaegeuk,
> >>
> >> Missed to apply this patch?
> >>
> >> On 2020/2/29 18:49, Chao Yu wrote:
> >>> due to f2fs_post_read_required() has did that.
> >>>
> >>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >>> ---
> >>> fs/f2fs/f2fs.h | 2 --
> >>> 1 file changed, 2 deletions(-)
> >>>
> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >>> index f4bcbbd5e9ed..882f9ad3445b 100644
> >>> --- a/fs/f2fs/f2fs.h
> >>> +++ b/fs/f2fs/f2fs.h
> >>> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> >>> return true;
> >>> if (f2fs_is_multi_device(sbi))
> >>> return true;
> >>> - if (f2fs_compressed_file(inode))
> >>> - return true;
> >
> > I thought that we can keep this to avoid any confusion when porting to old
> > production kernel which uses ICE.
>
> That old kernel w/ ICE doesn't have f2fs_post_read_required(), right?
We do have.
>
> I thought we backport features with order of the time fsverity/compression
> feature was introduced, then f2fs_post_read_required() should be there
> when we backport compression feature.
>
> Thanks,
>
> >
> >>> /*
> >>> * for blkzoned device, fallback direct IO to buffered IO, so
> >>> * all IOs can be serialized by log-structured write.
> >>>
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
2020-03-25 2:17 ` Jaegeuk Kim
@ 2020-03-25 2:20 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-03-25 2:20 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-kernel, linux-f2fs-devel
On 2020/3/25 10:17, Jaegeuk Kim wrote:
> On 03/25, Chao Yu wrote:
>> On 2020/3/24 23:43, Jaegeuk Kim wrote:
>>> On 03/24, Chao Yu wrote:
>>>> Jaegeuk,
>>>>
>>>> Missed to apply this patch?
>>>>
>>>> On 2020/2/29 18:49, Chao Yu wrote:
>>>>> due to f2fs_post_read_required() has did that.
>>>>>
>>>>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>>>>> ---
>>>>> fs/f2fs/f2fs.h | 2 --
>>>>> 1 file changed, 2 deletions(-)
>>>>>
>>>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>>>>> index f4bcbbd5e9ed..882f9ad3445b 100644
>>>>> --- a/fs/f2fs/f2fs.h
>>>>> +++ b/fs/f2fs/f2fs.h
>>>>> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
>>>>> return true;
>>>>> if (f2fs_is_multi_device(sbi))
>>>>> return true;
>>>>> - if (f2fs_compressed_file(inode))
>>>>> - return true;
>>>
>>> I thought that we can keep this to avoid any confusion when porting to old
>>> production kernel which uses ICE.
>>
>> That old kernel w/ ICE doesn't have f2fs_post_read_required(), right?
>
> We do have.
Well, so I didn't catch your point why we will confuse. :P
>
>>
>> I thought we backport features with order of the time fsverity/compression
>> feature was introduced, then f2fs_post_read_required() should be there
>> when we backport compression feature.
>>
>> Thanks,
>>
>>>
>>>>> /*
>>>>> * for blkzoned device, fallback direct IO to buffered IO, so
>>>>> * all IOs can be serialized by log-structured write.
>>>>>
>>> .
>>>
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-25 2:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-29 10:49 [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check Chao Yu
2020-03-24 6:10 ` Chao Yu
2020-03-24 15:43 ` Jaegeuk Kim
2020-03-25 1:26 ` Chao Yu
2020-03-25 2:17 ` Jaegeuk Kim
2020-03-25 2:20 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).