From: "Theodore Ts'o" <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org
Cc: Eric Biggers <ebiggers@kernel.org>, Theodore Ts'o <tytso@mit.edu>
Subject: [f2fs-dev] [PATCH 1/2] writeback: avoid double-writing the inode on a lazytime expiration
Date: Thu, 19 Mar 2020 22:52:54 -0400 [thread overview]
Message-ID: <20200320025255.1705972-1-tytso@mit.edu> (raw)
In-Reply-To: <20200320024639.GH1067245@mit.edu>
In the case that an inode has dirty timestamp for longer than the
lazytime expiration timeout (or if all such inodes are being flushed
out due to a sync or syncfs system call), we need to inform the file
system that the inode is dirty so that the inode's timestamps can be
copied out to the on-disk data structures. That's because if the file
system supports lazytime, it will have ignored the dirty_inode(inode,
I_DIRTY_TIME) notification when the timestamp was modified in memory.q
Previously, this was accomplished by calling mark_inode_dirty_sync(),
but that has the unfortunate side effect of also putting the inode the
writeback list, and that's not necessary in this case, since we will
immediately call write_inode() afterwards.
Eric Biggers noticed that this was causing problems for fscrypt after
the key was removed[1].
[1] https://lore.kernel.org/r/20200306004555.GB225345@gmail.com
Reported-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
fs/fs-writeback.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 76ac9c7d32ec..867454997c9d 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1504,8 +1504,9 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc)
spin_unlock(&inode->i_lock);
- if (dirty & I_DIRTY_TIME)
- mark_inode_dirty_sync(inode);
+ /* This was a lazytime expiration; we need to tell the file system */
+ if (dirty & I_DIRTY_TIME_EXPIRED && inode->i_sb->s_op->dirty_inode)
+ inode->i_sb->s_op->dirty_inode(inode, I_DIRTY_SYNC);
/* Don't write the inode if only I_DIRTY_PAGES was set */
if (dirty & ~I_DIRTY_PAGES) {
int err = write_inode(inode, wbc);
--
2.24.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-03-20 2:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 0:45 [f2fs-dev] lazytime causing inodes to remain dirty after sync? Eric Biggers
2020-03-07 2:00 ` [f2fs-dev] [PATCH] writeback: avoid double-writing the inode on a lazytime expiration Theodore Ts'o
2020-03-11 3:20 ` Eric Biggers
2020-03-11 12:57 ` Theodore Y. Ts'o
2020-03-12 0:07 ` Dave Chinner
2020-03-12 14:34 ` Christoph Hellwig
2020-03-12 22:39 ` Dave Chinner
2020-03-20 2:46 ` Theodore Y. Ts'o
2020-03-20 2:52 ` Theodore Ts'o [this message]
2020-03-20 2:52 ` [f2fs-dev] [PATCH 2/2] writeback, xfs: call dirty_inode() with I_DIRTY_TIME_EXPIRED when appropriate Theodore Ts'o
2020-03-23 17:58 ` Theodore Y. Ts'o
2020-03-24 8:37 ` Christoph Hellwig
2020-03-24 18:43 ` Theodore Y. Ts'o
2020-03-25 9:20 ` [f2fs-dev] [PATCH 1/2] writeback: avoid double-writing the inode on a lazytime expiration Christoph Hellwig
2020-03-25 15:21 ` Theodore Y. Ts'o
2020-03-25 15:47 ` Darrick J. Wong
2020-03-11 23:54 ` [f2fs-dev] [PATCH] " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320025255.1705972-1-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).