linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check
Date: Tue, 24 Mar 2020 19:17:02 -0700	[thread overview]
Message-ID: <20200325021702.GC198420@google.com> (raw)
In-Reply-To: <b0306fcf-27f2-20ab-9e5b-e54a924d4a61@huawei.com>

On 03/25, Chao Yu wrote:
> On 2020/3/24 23:43, Jaegeuk Kim wrote:
> > On 03/24, Chao Yu wrote:
> >> Jaegeuk,
> >>
> >> Missed to apply this patch?
> >>
> >> On 2020/2/29 18:49, Chao Yu wrote:
> >>> due to f2fs_post_read_required() has did that.
> >>>
> >>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >>> ---
> >>>  fs/f2fs/f2fs.h | 2 --
> >>>  1 file changed, 2 deletions(-)
> >>>
> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >>> index f4bcbbd5e9ed..882f9ad3445b 100644
> >>> --- a/fs/f2fs/f2fs.h
> >>> +++ b/fs/f2fs/f2fs.h
> >>> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> >>>  		return true;
> >>>  	if (f2fs_is_multi_device(sbi))
> >>>  		return true;
> >>> -	if (f2fs_compressed_file(inode))
> >>> -		return true;
> > 
> > I thought that we can keep this to avoid any confusion when porting to old
> > production kernel which uses ICE.
> 
> That old kernel w/ ICE doesn't have f2fs_post_read_required(), right?

We do have.

> 
> I thought we backport features with order of the time fsverity/compression
> feature was introduced, then f2fs_post_read_required() should be there
> when we backport compression feature.
> 
> Thanks,
> 
> > 
> >>>  	/*
> >>>  	 * for blkzoned device, fallback direct IO to buffered IO, so
> >>>  	 * all IOs can be serialized by log-structured write.
> >>>
> > .
> > 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-03-25  2:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 10:49 [f2fs-dev] [PATCH] f2fs: remove redundant compress inode check Chao Yu
2020-03-24  6:10 ` Chao Yu
2020-03-24 15:43   ` Jaegeuk Kim
2020-03-25  1:26     ` Chao Yu
2020-03-25  2:17       ` Jaegeuk Kim [this message]
2020-03-25  2:20         ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325021702.GC198420@google.com \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).