From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino
Date: Tue, 5 May 2020 08:31:39 -0700 [thread overview]
Message-ID: <20200505153139.201697-1-jaegeuk@kernel.org> (raw)
We had to grab the inode before retrieving i_ino.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/file.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index a0a4413d6083b..9d4c3e3503567 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -168,6 +168,7 @@ static const struct vm_operations_struct f2fs_file_vm_ops = {
static int get_parent_ino(struct inode *inode, nid_t *pino)
{
struct dentry *dentry;
+ struct inode *parent;
inode = igrab(inode);
dentry = d_find_any_alias(inode);
@@ -175,8 +176,13 @@ static int get_parent_ino(struct inode *inode, nid_t *pino)
if (!dentry)
return 0;
- *pino = parent_ino(dentry);
+ parent = igrab(d_inode(dentry->d_parent));
dput(dentry);
+ if (!parent)
+ return 0;
+
+ *pino = parent->i_ino;
+ iput(parent);
return 1;
}
--
2.26.2.526.g744177e7f7-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2020-05-05 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 15:31 Jaegeuk Kim [this message]
2020-05-05 16:58 ` [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino Eric Biggers
2020-05-05 17:59 ` Eric Biggers
2020-05-05 18:20 ` Jaegeuk Kim
2020-05-05 18:13 ` Jaegeuk Kim
2020-05-05 18:19 ` Eric Biggers
2020-05-05 18:49 ` Jaegeuk Kim
2020-05-05 19:01 ` Eric Biggers
2020-05-05 19:08 ` Jaegeuk Kim
2020-05-06 0:14 ` Gao Xiang
2020-05-06 1:24 ` Eric Biggers
2020-05-06 1:58 ` Gao Xiang via Linux-f2fs-devel
2020-05-06 6:47 ` Gao Xiang
2020-05-06 19:16 ` Eric Biggers
2020-05-06 22:36 ` Gao Xiang
2020-05-07 6:38 ` Chao Yu
2020-05-07 7:23 ` Gao Xiang
2020-05-06 6:55 ` Chao Yu
2020-05-07 6:30 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505153139.201697-1-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).