From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B9DC433DF for ; Mon, 18 May 2020 17:54:13 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 988B9207C4; Mon, 18 May 2020 17:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="N3xHm3Pu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ZuLANFI5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nyph8D8E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988B9207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jajxq-0002df-Vt; Mon, 18 May 2020 17:54:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jajxp-0002dG-OO for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 May 2020 17:54:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rik9AjREJ8Zw+GwFtnQnVJuu6aWcJW/PaAkQTnnqj6Q=; b=N3xHm3Pujyj9u1KBFgmg0XZrjd 27Pjsc+34A9wRORTfQrNmhp5ZaIxy3WAMDZQ0DJiJ6tYXqoVhnZ9TcJsCsCo2Diyo1BtuBdnpRfv4 ArkL8pzWK1NakZxtZbxqvuVyVvu4REi+M/v1LAwomCgeRB0CXLzSfBVZUNz9vQJEql5I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rik9AjREJ8Zw+GwFtnQnVJuu6aWcJW/PaAkQTnnqj6Q=; b=ZuLANFI5OUmJX4YwhpdXpktklx mp/fMkJC67Viprhl8dOaK4i0F83SL0Xa6PTiUqKdKylelwJcSBshSCZTxoT1tL7CvPPwliazpZEw9 kLbSjZpQq68fT9iwgGkX7O7ib3ekIgsLAnw/v1W3ZrWiOsnSOFgoL2jk43dpnCGzymXU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jajxo-00EDsc-1L for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 May 2020 17:54:09 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB45220826; Mon, 18 May 2020 17:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589824441; bh=FGetf+iVgy0vcrFX5izmqoZB7XMZZxHn5IEkcjsJXMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nyph8D8EtgCp2cujLjccSTM+tAFK5nAoCfNCnEw1Hu786e9LMfic2dssZoVavfoEx LhGiKRQxbUfg1E+TjlgUbRoRTdasRXmGPceJ9d2dxt5nn4hsvEWAGsuSt3JLOTVpuO aVjJOs7d0f3qaMejLDDZFFUKGak54OZHObqMUKBw= Date: Mon, 18 May 2020 10:54:00 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200518175400.GA218254@google.com> References: <20200515021554.226835-1-jaegeuk@kernel.org> <9ba6e5ef-068d-a925-1eb9-107b0523666c@huawei.com> <20200515144509.GA46028@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1jajxo-00EDsc-1L Subject: Re: [f2fs-dev] [PATCH] f2fs: flush dirty meta pages when flushing them X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/18, Chao Yu wrote: > On 2020/5/15 22:45, Jaegeuk Kim wrote: > > On 05/15, Chao Yu wrote: > >> On 2020/5/15 10:15, Jaegeuk Kim wrote: > >>> Let's guarantee flusing dirty meta pages to avoid infinite loop. > >> > >> What's the root cause? Race case or meta page flush failure? > > > > Investigating, but at least, this can avoid the inifinite loop there. > > Hmm... this fix may cover the root cause.. We're getting reached out to one related to this issue where single SSA page is dirtied at the moment. Anyway, I think it'd be fine to get this as we can detect any fs consistency issue by fsck. So far, I haven't seen any problem in all my local stress tests. > > Thanks, > > > > > V2: > > > >>From c60ce8e7178004fd6cba96e592247e43b5fd98d8 Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim > > Date: Wed, 13 May 2020 21:12:53 -0700 > > Subject: [PATCH] f2fs: flush dirty meta pages when flushing them > > > > Let's guarantee flusing dirty meta pages to avoid infinite loop. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/checkpoint.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > index 620a386d82c1a..3dc3ac6fe1432 100644 > > --- a/fs/f2fs/checkpoint.c > > +++ b/fs/f2fs/checkpoint.c > > @@ -1266,6 +1266,9 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, int type) > > if (unlikely(f2fs_cp_error(sbi))) > > break; > > > > + if (type == F2FS_DIRTY_META) > > + f2fs_sync_meta_pages(sbi, META, LONG_MAX, > > + FS_CP_META_IO); > > io_schedule_timeout(DEFAULT_IO_TIMEOUT); > > } > > finish_wait(&sbi->cp_wait, &wait); > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel