From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C41FC433E1 for ; Thu, 28 May 2020 16:49:46 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E920207F5 for ; Thu, 28 May 2020 16:49:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Rbk/h1bG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="JEUn6GhV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="dZ/4oQHk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E920207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jeLiz-0006vV-S7; Thu, 28 May 2020 16:49:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeLiz-0006vI-3K for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 May 2020 16:49:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=Rbk/h1bGV7MKzogKUXAxTOyAEg H+Gw9u/dRvlBVaeLJsBruEfwrtT8slVxgVPiXY/jh4mrTTJIhh6uuTYxi1ssBI9IkPkPdhyHNoHVQ SGp9GacJGGUTmKZ4FA2HPxwuFRf7jrN9s+d2i7+l7IoF2ynPNNbwa6LWb2XnUeHb+Klk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=JEUn6GhVCyIXQ5dnPBcKpj9bem pO85XlxgGnRw5yOqS9txtX/w1jxSnePTIuZbp7iPo73RwVBKh3yp+IEPvPoFgqpZIXSOpkIMLSvHU +ZdYOgfKHeWHBdZbhy7Bn3hRYa1dk57/ME8lt8BwU5tmHOqKDZ/FpOQS9fdJyrDq6rqc=; Received: from mail-ed1-f65.google.com ([209.85.208.65]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jeLis-00B3TC-QK for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 May 2020 16:49:45 +0000 Received: by mail-ed1-f65.google.com with SMTP id k19so619476edv.9 for ; Thu, 28 May 2020 09:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=dZ/4oQHkI3iFVl6Q4XDatBaCWT8WDKIy43ty6iL5UZV9y8w2Mwc2zwtaHwr00vostz c8tS4BvevPCZZt4NdTss07rL4pzKusdIZLJ1Zm9Z3FuwwbTD2hfas29vKN5+7iQ8CBt4 fMhXjwXce9iKSnXnt3Jr4qQvtVDCYiR2OFQFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=XvpXO5o7sz4OJf+rEvn82vrWLSRoLgNlaad+Y2Gf4M/vk2y2dS5xZUmVqIHqqbQmhq /GZ9KpOxADeUV9UkdXDy4lDP6vzkKtsA0fp8xhwikCqvFAWN0MUhDsVr7hKgZKId6wCa 9EsvVoXxcGV16wW4IZN15J6i6ZXlmvQ0e7NVS87KAHpa+nsfbkTtmuokjNP5zSqcRsnU KDnINxuI0blgklQ9pMMZIoFN6mSmCYrx9ArMDzOvL55wxma2QUrzCxCD0l8ldNeTB6rC 5kPufzelGIZZ1i44V59WVD9cYsxInV9qOXrJrIWMkmRpcejY6LOoeQwv1ix1akPK8k5r a+Wg== X-Gm-Message-State: AOAM530TNi7yv78F49daAD/u+uPwgdEdAeDvwKB4aQv9/hk81N4DU6AT tLYjSGv5tlS+X1NeLKqHdTOeUk3qrnqwD54V X-Google-Smtp-Source: ABdhPJx43EFGY79zZc9WHOq4nlucrHubXscZYsQcdCStmKVBziBJ4zuFJn23rjI3pradupO/1Tk0Ig== X-Received: by 2002:adf:ff82:: with SMTP id j2mr4130619wrr.375.1590684083033; Thu, 28 May 2020 09:41:23 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:d125]) by smtp.gmail.com with ESMTPSA id y66sm6698899wmy.24.2020.05.28.09.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 09:41:22 -0700 (PDT) Date: Thu, 28 May 2020 17:41:21 +0100 From: Chris Down To: Naresh Kamboju Message-ID: <20200528164121.GA839178@chrisdown.name> References: <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200528150310.GG27484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.2 (2020-05-25) X-Headers-End: 1jeLis-00B3TC-QK Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkft-triage@lists.linaro.org, Michal Hocko , linux-mm , Yafang Shao , Andreas Dilger , Cgroups , Andrea Arcangeli , Anders Roxell , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , open list , "Linux F2FS DEV, Mailing List" , Johannes Weiner , Andrew Morton , Roman Gushchin Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Naresh Kamboju writes: >On Thu, 28 May 2020 at 20:33, Michal Hocko wrote: >> >> On Fri 22-05-20 02:23:09, Naresh Kamboju wrote: >> > My apology ! >> > As per the test results history this problem started happening from >> > Bad : next-20200430 (still reproducible on next-20200519) >> > Good : next-20200429 >> > >> > The git tree / tag used for testing is from linux next-20200430 tag and reverted >> > following three patches and oom-killer problem fixed. >> > >> > Revert "mm, memcg: avoid stale protection values when cgroup is above >> > protection" >> > Revert "mm, memcg: decouple e{low,min} state mutations from protectinn checks" >> > Revert "mm-memcg-decouple-elowmin-state-mutations-from-protection-checks-fix" >> >> The discussion has fragmented and I got lost TBH. >> In http://lkml.kernel.org/r/CA+G9fYuDWGZx50UpD+WcsDeHX9vi3hpksvBAWbMgRZadb0Pkww@mail.gmail.com >> you have said that none of the added tracing output has triggered. Does >> this still hold? Because I still have a hard time to understand how >> those three patches could have the observed effects. > >On the other email thread [1] this issue is concluded. > >Yafang wrote on May 22 2020, > >Regarding the root cause, my guess is it makes a similar mistake that >I tried to fix in the previous patch that the direct reclaimer read a >stale protection value. But I don't think it is worth to add another >fix. The best way is to revert this commit. This isn't a conclusion, just a guess (and one I think is unlikely). For this to reliably happen, it implies that the same race happens the same way each time. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel