From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E1DC433E0 for ; Wed, 24 Jun 2020 06:04:13 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1BDB2085B for ; Wed, 24 Jun 2020 06:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="d4HjeBXe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="dhzKwq7W"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="po3bfXB9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1BDB2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jnyW5-00015n-Du; Wed, 24 Jun 2020 06:04:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnyW3-00015f-V6 for linux-f2fs-devel@lists.sourceforge.net; Wed, 24 Jun 2020 06:04:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+d9GiKN34fRRDo0wEbPZEKkcvPO1+U3THTvcbnSop94=; b=d4HjeBXels7onN/Hfjhe55UPjl k8okyHjrFOk+jUFGoTlxw+XIX7BIKxFbNNNoa8OtMwXbSM0joGXEem9rHjhfMtZI1vNu7mmlX/i+k njm/aJcO2cTlgfiT4n1517oDCxBoZrjSfHEd+Smz4I81kpfDcGXYKsNRqmMkgsuS7j2o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+d9GiKN34fRRDo0wEbPZEKkcvPO1+U3THTvcbnSop94=; b=dhzKwq7WZwLehKZKh0Cs19cAbz pKDrccpzqQB61qKlVWVAUQrLBHpRa31BNJjP1JCYYHYx9vKH+7GD8akskNR1oBxnwGYzjGsto91Yr X66MoWANgWq7S47AIFJB5KdIP3wjkaEU1QI+1p5MWEpxNUnGKglfcLv/s5Q7tPQA2InY=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jnyW2-00GjDS-U0 for linux-f2fs-devel@lists.sourceforge.net; Wed, 24 Jun 2020 06:04:11 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11AC92085B; Wed, 24 Jun 2020 06:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592978645; bh=STmnuLbp6dqBamgAzJ+Ue/+bNkc6g/1tpfJs2y+gU6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=po3bfXB92hJ+PijyLMwHXbS/arxBw/0IUAsnaYskimBhp5qtvm5z+v8pGM+WgW9eW FLe98JcBQR5dGhNpYT2AcM037Hpb1EdSMM5PBYfhnf2Wgpw7k7/8mYfd7JPRk5E8No teVgpd0E/A1IgM2mFReeceA8sMDJhn8YuudMvMdA= Date: Tue, 23 Jun 2020 23:04:03 -0700 From: Eric Biggers To: Daniel Rosenberg Message-ID: <20200624060403.GH844@sol.localdomain> References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-5-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624043341.33364-5-drosen@google.com> X-Headers-End: 1jnyW2-00GjDS-U0 Subject: Re: [f2fs-dev] [PATCH v9 4/4] ext4: Use generic casefolding support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jun 23, 2020 at 09:33:41PM -0700, Daniel Rosenberg wrote: > This switches ext4 over to the generic support provided in > commit 5f829feca774 ("fs: Add standard casefolding support") Commit IDs aren't determined until the patches are applied. It's possible for the person applying the patches to fix them, but in general people will forget, so it's better not to include non-stable commit IDs. Also, a sentence explaining *why* this change is good would be helpful. Commit messages should always have a *why* unless it's obvious. Likewise for the f2fs commit. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel