linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Nicolas Boichat <drinkcat@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Peter Chen <peter.chen@nxp.com>,
	"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
	Rafael Aquini <aquini@redhat.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Todor Tomov <todor.too@gmail.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Howells <dhowells@redhat.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Will Deacon <will@kernel.org>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Kees Cook <keescook@chromium.org>,
	devel@driverdev.osuosl.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Jayshri Pawar <jpawar@cadence.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Andy Gross <agross@kernel.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	linux-media@vger.kernel.org, Pawel Laszczak <pawell@cadence.com>,
	Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Roger Quadros <rogerq@ti.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Colin Ian King <colin.king@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Divya Indi <divya.indi@oracle.com>
Subject: [f2fs-dev] [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg
Date: Sat, 27 Jun 2020 15:03:04 +0800	[thread overview]
Message-ID: <20200627070307.516803-2-drinkcat@chromium.org> (raw)
In-Reply-To: <20200627070307.516803-1-drinkcat@chromium.org>

trace_printk should not be used in production code, replace it
call with dev_dbg.

Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>

---

Unclear why a trace_printk was used in the first place, it's
possible that some rate-limiting is necessary here.

 drivers/usb/cdns3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 5e24c2e57c0d8c8..c303ab7c62d1651 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -421,7 +421,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
 		if ((priv_req->flags & REQUEST_INTERNAL) ||
 		    (priv_ep->flags & EP_TDLCHK_EN) ||
 			priv_ep->use_streams) {
-			trace_printk("Blocking external request\n");
+			dev_dbg(priv_dev->dev, "Blocking external request\n");
 			return ret;
 		}
 	}
-- 
2.27.0.212.ge8ba1cc988-goog



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-06-27  7:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27  7:03 [f2fs-dev] [PATCH 0/4] Detect and remove trace_printk Nicolas Boichat
2020-06-27  7:03 ` Nicolas Boichat [this message]
2020-06-29  3:31   ` [f2fs-dev] [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg Peter Chen
     [not found]   ` <878sfanzft.fsf@kernel.org>
2020-07-24  0:17     ` Nicolas Boichat
2020-06-27  7:03 ` [f2fs-dev] [PATCH 2/4] media: atomisp: Replace trace_printk by pr_info Nicolas Boichat
2020-06-27  7:03 ` [f2fs-dev] [PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only Nicolas Boichat
2020-06-27  7:03 ` [f2fs-dev] [PATCH v2 4/4] kernel/trace: Add TRACING_ALLOW_PRINTK config option Nicolas Boichat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627070307.516803-2-drinkcat@chromium.org \
    --to=drinkcat@chromium.org \
    --cc=adobriyan@gmail.com \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=aquini@redhat.com \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=colin.king@canonical.com \
    --cc=daniel@ffwll.ch \
    --cc=devel@driverdev.osuosl.org \
    --cc=dhowells@redhat.com \
    --cc=divya.indi@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gpiccoli@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jaegeuk@kernel.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jpawar@cadence.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=rogerq@ti.com \
    --cc=rostedt@goodmis.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sam@ravnborg.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=todor.too@gmail.com \
    --cc=tomas.winkler@intel.com \
    --cc=will@kernel.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).