From: Eric Biggers <ebiggers@kernel.org>
To: tytso@mit.edu
Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Satya Tangirala <satyat@google.com>
Subject: Re: [f2fs-dev] [PATCH v4 4/4] ext4: add inline encryption support
Date: Wed, 8 Jul 2020 10:34:52 -0700 [thread overview]
Message-ID: <20200708173452.GA32199@sol.localdomain> (raw)
In-Reply-To: <20200708171812.GF1627842@mit.edu>
On Wed, Jul 08, 2020 at 01:18:12PM -0400, tytso@mit.edu wrote:
> On Thu, Jul 02, 2020 at 01:56:07AM +0000, Satya Tangirala wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Wire up ext4 to support inline encryption via the helper functions which
> > fs/crypto/ now provides. This includes:
> >
> > - Adding a mount option 'inlinecrypt' which enables inline encryption
> > on encrypted files where it can be used.
> >
> > - Setting the bio_crypt_ctx on bios that will be submitted to an
> > inline-encrypted file.
> >
> > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for
> > this part, since ext4 sometimes uses ll_rw_block() on file data.
> >
> > - Not adding logically discontiguous data to bios that will be submitted
> > to an inline-encrypted file.
> >
> > - Not doing filesystem-layer crypto on inline-encrypted files.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Co-developed-by: Satya Tangirala <satyat@google.com>
> > Signed-off-by: Satya Tangirala <satyat@google.com>
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
>
Thanks Ted. I've applied this patch to fscrypt.git#master for 5.9.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-08 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 1:56 [f2fs-dev] [PATCH v4 0/4] Inline Encryption Support for fscrypt Satya Tangirala via Linux-f2fs-devel
2020-07-02 1:56 ` [f2fs-dev] [PATCH v4 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala via Linux-f2fs-devel
2020-07-08 17:07 ` tytso
2020-07-02 1:56 ` [f2fs-dev] [PATCH v4 2/4] fscrypt: add inline encryption support Satya Tangirala via Linux-f2fs-devel
2020-07-08 17:14 ` tytso
2020-07-02 1:56 ` [f2fs-dev] [PATCH v4 3/4] f2fs: " Satya Tangirala via Linux-f2fs-devel
2020-07-02 1:56 ` [f2fs-dev] [PATCH v4 4/4] ext4: " Satya Tangirala via Linux-f2fs-devel
2020-07-08 17:18 ` tytso
2020-07-08 17:34 ` Eric Biggers [this message]
2020-07-07 18:08 ` [f2fs-dev] [PATCH v4 0/4] Inline Encryption Support for fscrypt Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708173452.GA32199@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).