From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CD3C433E0 for ; Thu, 9 Jul 2020 22:30:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 380EC2070E; Thu, 9 Jul 2020 22:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="A8cJvO24"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Yk7zzuLG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+WR+Y2L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 380EC2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jtf46-0003qh-5l; Thu, 09 Jul 2020 22:30:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtf44-0003qZ-NL for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jul 2020 22:30:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7dqJz7HGmtaLQ2ePle3NJl+4ZCkTyDnaQwDTdbZVg0U=; b=A8cJvO24wMq7ySSjKniFzRy3kb fUcv5Adk1TCFRqsL9Q7cIXAaLM93yivAmPnEQtc0yAalrorXOhOO5AGRULZ+qA9gvWSc40vlTqpDR U6DCkJ6wcWEwQVtVDpCNAf3FQY8/Lla3G+Be8X6sVU5yj40z11jpUkVDgcetHBNPUmDI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7dqJz7HGmtaLQ2ePle3NJl+4ZCkTyDnaQwDTdbZVg0U=; b=Yk7zzuLGa1ptei1Dd66XSZz7/R DzXyzqHF9CZS4fmi6nn2u6Y61IkCLzqKN/2nnW+rj9WB0X96bV05uMiuVCtuQc2uYiqWvxuEMxMru 76CT9ahph6wt5C6/T0fYqKG05VFte5me2TB8ldXBOIgx7apBakIXmsjigLoGWS313aDk=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jtf42-00FdI5-37 for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jul 2020 22:30:48 +0000 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8540B2070E; Thu, 9 Jul 2020 22:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594333835; bh=Dpn69SR1yUFPn66W7Fbbk1lCZ1fQTf5VGLdHh2L6pHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+WR+Y2LanZRhq8MC5xduHojOk8O3+XkAMqrAcK0GJHm1Uegqx4r0qOxZTCnB4eo+ 8Pz68buk00ixvCYM+O7sDEZwr/AFjVyiAAk7rL6gakndlg3018/druWwbuN6YlXRPs fEjJFYMNpIrs+615pkKDogPMr21H+id2N31Liccg= Date: Thu, 9 Jul 2020 15:30:34 -0700 From: Eric Biggers To: Satya Tangirala Message-ID: <20200709223034.GE3855682@gmail.com> References: <20200709194751.2579207-1-satyat@google.com> <20200709194751.2579207-5-satyat@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200709194751.2579207-5-satyat@google.com> X-Headers-End: 1jtf42-00FdI5-37 Subject: Re: [f2fs-dev] [PATCH 4/5] ext4: support direct I/O with fscrypt using blk-crypto X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jul 09, 2020 at 07:47:50PM +0000, Satya Tangirala wrote: > From: Eric Biggers > > Wire up ext4 with fscrypt direct I/O support. > > Signed-off-by: Eric Biggers > Signed-off-by: Satya Tangirala This commit message could use some more details. I think it should clarify that the direct I/O support is limited to cases where the filesystem has been mounted with '-o inlinecrypt' and CONFIG_BLK_INLINE_ENCRYPTION has been enabled, along with CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK if hardware support isn't present. As-is, it sounds a bit over-promising. Likewise for f2fs. We need to properly document this too. At the very least, in the fscrypt patch, Documentation/filesystems/fscrypt.rst needs to be updated because it currently says "Direct I/O is not supported on encrypted files." fscrypt.rst could also use some information about inline encryption. Currently inline encryption for fscrypt is only documented in the ext4 and f2fs documentation in the context of the inlinecrypt mount option. (Though, this suggestion applies even without direct I/O support.) - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel