From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18907C433DF for ; Fri, 10 Jul 2020 03:51:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D53522072E; Fri, 10 Jul 2020 03:51:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="b+8xpRDT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="lxM4WKpd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DRMSHRXg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D53522072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jtk46-0001Po-Bp; Fri, 10 Jul 2020 03:51:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtk44-0001Ph-Oi for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 03:51:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpsKeb3uxmH+mq7rBiY+RD5pKbjmjRor7JHY8owlD9E=; b=b+8xpRDTJu0hUPMiDEEEPpFoZw VXDCz9B9515qzlEs+baKGTLXKRkDFs963H+zQJBYM/V2R4OCx0DwBV80w/aXmNIc80MQDeigQiqCD mIxGAWkMnNCqCkUkqPCgDb2qiT0WbkbS/NYIB2rczwX7iJJROwWoo7dS6kIILTlNMJmE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YpsKeb3uxmH+mq7rBiY+RD5pKbjmjRor7JHY8owlD9E=; b=lxM4WKpd/DmXSMJvdodhAn9Hwl 62c8oIp8L9b0rNB1AYWxqb6FFb/iKCL6rn+BbNVmrt2Xi3ldGEBgXxXXQsjz0PHGSuI+tSKIHUeYR TCIX/zykUQIkGRHmjZckycT7qkeydMhfYvsoSbubC2XYXWmcFjYxCrT/7tbCDNGkduIk=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jtk3v-00CpPX-E2 for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 03:51:08 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F361D2072E; Fri, 10 Jul 2020 03:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594353054; bh=hObc9B15Ofq12aAQ4BtIME3uk1sIIW2p9hj83IUp0cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRMSHRXgW+6+9XZgjy5ubtuWyfVl2iQzIsm3m/Ihrvy+tdbGG18Tj92ewpb3jm47d v7GL054oxMje9ucMbtaSN1O/DXxSKJJCCK57sepC5g+T/dzJeJEYMfBFWX4IYlptg+ ABM+NKjFFSwPFGYNqPC/yKDjTNmOXIzRvP3jurWQ= Date: Thu, 9 Jul 2020 20:50:53 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200710035053.GH545837@google.com> References: <20200709053027.351974-1-jaegeuk@kernel.org> <2f4207db-57d1-5b66-f1ee-3532feba5d1f@huawei.com> <20200709190545.GA3001066@google.com> <20200710032616.GC545837@google.com> <01d0db54-eee1-f6cd-76c3-ebe59a7abae4@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01d0db54-eee1-f6cd-76c3-ebe59a7abae4@huawei.com> X-Headers-End: 1jtk3v-00CpPX-E2 Subject: Re: [f2fs-dev] [PATCH] f2fs: don't skip writeback of quota data X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 07/10, Chao Yu wrote: > On 2020/7/10 11:26, Jaegeuk Kim wrote: > > On 07/10, Chao Yu wrote: > >> On 2020/7/10 3:05, Jaegeuk Kim wrote: > >>> On 07/09, Chao Yu wrote: > >>>> On 2020/7/9 13:30, Jaegeuk Kim wrote: > >>>>> It doesn't need to bypass flushing quota data in background. > >>>> > >>>> The condition is used to flush quota data in batch to avoid random > >>>> small-sized udpate, did you hit any problem here? > >>> > >>> I suspect this causes fault injection test being stuck by waiting for inode > >>> writeback completion. With this patch, it has been running w/o any issue so far. > >>> I keep an eye on this. > >> > >> Hmmm.. so that this patch may not fix the root cause, and it may hiding the > >> issue deeper. > >> > >> How about just keeping this patch in our private branch to let fault injection > >> test not be stuck? until we find the root cause in upstream codes. > > > > Well, I don't think this hides something. When the issue happens, I saw inodes > > being stuck due to writeback while only quota has some dirty data. At that time, > > there was no dirty data page from other inodes. > > Okay, > > > > > More specifically, I suspect __writeback_inodes_sb_nr() gives WB_SYNC_NONE and > > waits for wb_wait_for_completion(). > > Did you record any callstack after the issue happened? I found this. [213389.297642] __schedule+0x2dd/0x780^M [213389.299224] schedule+0x55/0xc0^M [213389.300745] wb_wait_for_completion+0x56/0x90^M [213389.302469] ? wait_woken+0x80/0x80^M [213389.303997] __writeback_inodes_sb_nr+0xa8/0xd0^M [213389.305760] writeback_inodes_sb+0x4b/0x60^M [213389.307439] sync_filesystem+0x2e/0xa0^M [213389.308999] generic_shutdown_super+0x27/0x110^M [213389.310738] kill_block_super+0x27/0x50^M [213389.312327] kill_f2fs_super+0x76/0xe0 [f2fs]^M [213389.314014] deactivate_locked_super+0x3b/0x80^M [213389.315692] deactivate_super+0x3e/0x50^M [213389.317226] cleanup_mnt+0x109/0x160^M [213389.318718] __cleanup_mnt+0x12/0x20^M [213389.320177] task_work_run+0x70/0xb0^M [213389.321609] exit_to_usermode_loop+0x131/0x160^M [213389.323306] do_syscall_64+0x170/0x1b0^M [213389.324762] entry_SYSCALL_64_after_hwframe+0x44/0xa9^M [213389.326477] RIP: 0033:0x7fc4b5e6a35b^M > > Still I'm confused that why directory's data written could be skipped, but > quota's data couldn't, what's the difference? I suspect different blocking timing from cp_error between quota and dentry. e.g., we block dir operations right after cp_error, while quota can make dirty pages in more fine granularity. > > > > >> > >> Thanks, > >> > >>> > >>> Thanks, > >>> > >>>> > >>>> Thanks, > >>>> > >>>>> > >>>>> Signed-off-by: Jaegeuk Kim > >>>>> --- > >>>>> fs/f2fs/data.c | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > >>>>> index 44645f4f914b6..72e8b50e588c1 100644 > >>>>> --- a/fs/f2fs/data.c > >>>>> +++ b/fs/f2fs/data.c > >>>>> @@ -3148,7 +3148,7 @@ static int __f2fs_write_data_pages(struct address_space *mapping, > >>>>> if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) > >>>>> goto skip_write; > >>>>> > >>>>> - if ((S_ISDIR(inode->i_mode) || IS_NOQUOTA(inode)) && > >>>>> + if (S_ISDIR(inode->i_mode) && > >>>>> wbc->sync_mode == WB_SYNC_NONE && > >>>>> get_dirty_pages(inode) < nr_pages_to_skip(sbi, DATA) && > >>>>> f2fs_available_free_memory(sbi, DIRTY_DENTS)) > >>>>> > >>> . > >>> > > . > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel