From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B26C433DF for ; Fri, 10 Jul 2020 05:34:32 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A01A20720; Fri, 10 Jul 2020 05:34:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="b6rD5zHb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DMx2ESiS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SUHqfj0x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A01A20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jtlg6-0005gg-GM; Fri, 10 Jul 2020 05:34:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtlg4-0005gS-TN for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 05:34:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pVjWefAfqShBdQ1ZZJmJ6WwzyFiCXEB2I8I0n7n2VvA=; b=b6rD5zHbb3QSw5RLGNFVzXQicc 4e+tlWn5VGMhHEXLlT8/Cy7AHjKNzYoKYbEj00dFFbrh0OSQOpYpY9Ua78djQZVZHrhGA5iRxEXm1 hoOAOOFgRpwdrGyiEuYfrbDAZm7mAzU4ssyfv93NYiznazLatMHcaOKrNdwaO8VBbVGM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pVjWefAfqShBdQ1ZZJmJ6WwzyFiCXEB2I8I0n7n2VvA=; b=DMx2ESiSv7YwKp6boD1ux68wTS 3ZSL9P4Q3UZbEfpuXt2Hjei1ngwGkDEbU4Oe7KI5lLCjNN3hxKphmrImocM4AiYxiR35xrJTgRLrR 5fuW89l6B6MnynIlsU2D9bHkjIFekNZfeUPk7f54YKvE8jdtMpDOUa+HPYd74kTNYBi0=; Received: from casper.infradead.org ([90.155.50.34]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jtlg1-00Csfs-Fq for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 05:34:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pVjWefAfqShBdQ1ZZJmJ6WwzyFiCXEB2I8I0n7n2VvA=; b=SUHqfj0xDvAG/k3lfL1KEXLiV2 60PoTII6SdYLTmUHFeNDnuRi4A94mjv0BljVLGMx1uzxIWRZFKA/JoKuVBK/fS9c79Gt1D9WQJEnR ax0PRiqaz9VlGLTJ025lM0VOvZRrkcUlPyCJir7j4JfFtwZ4yA3+sxKhQNZuysRJU5L5JQqymDCss AiLX10BZ1YGeBBHGHKkXdbT19NKNg4OtqAoM6O7CcpNjxf7II92J/0zFOODZMjzhrrnkQWUetDlS8 HYwJiW4o1RVw+MrxIY3lMCAI97+j0afkuWH4B81BilyO++t9EKd+qQseW+nQdd7QoigjYp9Y9H47o 0RlKQclQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtlfi-0006zt-Ec; Fri, 10 Jul 2020 05:34:06 +0000 Date: Fri, 10 Jul 2020 06:34:06 +0100 From: Christoph Hellwig To: Satya Tangirala Message-ID: <20200710053406.GA25530@infradead.org> References: <20200709194751.2579207-1-satyat@google.com> <20200709194751.2579207-3-satyat@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200709194751.2579207-3-satyat@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1jtlg1-00Csfs-Fq Subject: Re: [f2fs-dev] [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, Eric Biggers , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote: > From: Eric Biggers > > Set bio crypt contexts on bios by calling into fscrypt when required, > and explicitly check for DUN continuity when adding pages to the bio. > (While DUN continuity is usually implied by logical block contiguity, > this is not the case when using certain fscrypt IV generation methods > like IV_INO_LBLK_32). I know it is asking you for more work, but instead of adding more features to the legacy direct I/O code, could you just switch the user of it (I guess this is for f2f2?) to the iomap one? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel