From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FB5C433DF for ; Fri, 17 Jul 2020 01:56:46 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C582076D; Fri, 17 Jul 2020 01:56:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="CGVaOjxD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="PlU0DPv6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="k5OHMqB0"; dkim=neutral (0-bit key) header.d=google.com header.i=@google.com header.b="fF8SXmuJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C582076D Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tH9hxX0A8uWuc5luOuJ0OZ7jhjZCYWY7z1oLaSnxSzQ=; b=CGVaOjxDGTJxE8AxWH8PgmaJa ie37CN1mgKrdMo0+Bz33+mevG9G3FqICgDOF7Mce9XwYPG1uXaI5Kw5Tnc2x5n8jVY8iTJPbqKKt1 DnFkFxmUFLSyUTOnLYMTKIrYWDjiOMaRwaztmmEmk503RR5oyECX90yagGiAcbtmypeqE=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jwFcD-00036V-KW; Fri, 17 Jul 2020 01:56:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwFcB-00036I-5x for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Jul 2020 01:56:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qsRBKN8QLdPNyhcwSV+uq9z8S14OK4+shsMWXoSHano=; b=PlU0DPv6P0bneKyNY9vB1ga2Bo YNQXG13BRYN7iFTMlHUneeha3DIg0lcvZ75EoYXsPU0mpXN9+U21Qj+IR9SZ26ek+LQTPj7E9rYDn DWvKjWvBBvbTRHfTDFwunGwcS1mU8cTY6KuIl5+wMH53qaZ6lKkoJ5rbNnUWX7oUaCb8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qsRBKN8QLdPNyhcwSV+uq9z8S14OK4+shsMWXoSHano=; b=k5OHMqB07+eCQfckTdKmS0sasd KgOF/Mq4GvgPftWKxdr9swuFD6H/5gUgMMrEbvhJbH/2/JWjk23UzFFl3bQz9zyFZBpI7fgaqxQoH zLmT0l6zBJKru/3hEKc/sCs2FltD+V81wz1XGzbuZ+/tSmRZZLADrfzDbH8cBuA46qpA=; Received: from mail-pf1-f195.google.com ([209.85.210.195]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jwFc5-003m8m-Ix for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Jul 2020 01:56:43 +0000 Received: by mail-pf1-f195.google.com with SMTP id a24so4616449pfc.10 for ; Thu, 16 Jul 2020 18:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qsRBKN8QLdPNyhcwSV+uq9z8S14OK4+shsMWXoSHano=; b=fF8SXmuJ5dp+F3PTM2our2J4E+hDhHA0p3iDcnB/O91rUNgrshAnIKppEVbLV9YzFA 4QV6KsmrWTalXlq6RfGoNa2i6J0lQkPm1oQS9mrzp5Iem/XFthEytoyzvTkpI8bk1neF ktTuLqsJ+g/DIvPLl/T+rEzFialug4jEbUek8pxOaE5o+AQKkHtPIHzgZoJ2YQGJmKhm uM82+Ak3HfxCJGEq8acmRO6w2zJLKq7xc3J9NI1zbXTRnM+AN/FMNGvvYJ17dAE0RFPy e1OIEHs7M7VC04J+vLieQoy1BO54eelNvQbGd9zmkoJ4+YAeR2fTBZi1H3+0AXZDoStB JYeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qsRBKN8QLdPNyhcwSV+uq9z8S14OK4+shsMWXoSHano=; b=DsaA6Foux2821tx04QUnCVzyDoyjv1xFZBdSfZwt4yVxtAz1D+PfBWlfoJJGxAhcYe UVcau+xbx74tqqvZvfpxFpf3kbT6MfnA9Fw82qjKLuto184rJV6jOZHMLjxZUnfzocuh v0KWEWpc0m6DUphRY4fRvuLdX/CIxBCmyIp8XHxLwR+zRTdbgDEDlw1gLXw4r8rIVKiy HdhgQwNfOzGDHGaC47obZ88QlpzWwHM/iQiM4Xda+kHBtroJvdbpYHMdoX1N1vbhJOn3 Z2f6w24Hr2rVJfJ6ZXSx9/Kcka/T6EbTs/7zohMAmHKZyBfyhl4Ljz0dkbmX/BXnz5E3 5iUQ== X-Gm-Message-State: AOAM532/JFlhpMdc6dJnvPe6BwXTndjCdPs5vTXO9bmWDXi2l8OEwKof ZKOud4FN5taVaAgvRXpHqrUxdw== X-Google-Smtp-Source: ABdhPJw8pEBcXlCRGQ2zK0krljhxRjXz/nER5WspRB+U1hDcSxVBK7VwJySfVnXQhiryBo/CryuPIQ== X-Received: by 2002:a63:f90f:: with SMTP id h15mr6578417pgi.53.1594950991806; Thu, 16 Jul 2020 18:56:31 -0700 (PDT) Received: from google.com (124.190.199.35.bc.googleusercontent.com. [35.199.190.124]) by smtp.gmail.com with ESMTPSA id d9sm5835817pfd.133.2020.07.16.18.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 18:56:31 -0700 (PDT) Date: Fri, 17 Jul 2020 01:56:27 +0000 To: Eric Biggers Message-ID: <20200717015627.GA82163@google.com> References: <20200709194751.2579207-1-satyat@google.com> <20200709194751.2579207-3-satyat@google.com> <20200710053406.GA25530@infradead.org> <20200713183619.GC722906@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713183619.GC722906@gmail.com> X-Headers-End: 1jwFc5-003m8m-Ix Subject: Re: [f2fs-dev] [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Satya Tangirala via Linux-f2fs-devel Reply-To: Satya Tangirala Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jul 13, 2020 at 11:36:19AM -0700, Eric Biggers wrote: > On Fri, Jul 10, 2020 at 06:34:06AM +0100, Christoph Hellwig wrote: > > On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote: > > > From: Eric Biggers > > > > > > Set bio crypt contexts on bios by calling into fscrypt when required, > > > and explicitly check for DUN continuity when adding pages to the bio. > > > (While DUN continuity is usually implied by logical block contiguity, > > > this is not the case when using certain fscrypt IV generation methods > > > like IV_INO_LBLK_32). > > > > I know it is asking you for more work, but instead of adding more > > features to the legacy direct I/O code, could you just switch the user > > of it (I guess this is for f2f2?) to the iomap one? > > Eventually we should do that, as well as convert f2fs's fiemap, bmap, and llseek > to use iomap. However there's a nontrivial barrier to entry, at least for > someone who isn't an expert in iomap, especially since f2fs currently doesn't > use iomap at all and thus doesn't have an iomap_ops implementation. And using > ext4 as an example, there will be some subtle cases that need to be handled. > > Satya says he's looking into it; we'll see what he can come up with and what the > f2fs developers say. > > If it turns out to be difficult and people think this patchset is otherwise > ready, we probably shouldn't hold it up on that. This is a very small patch, > and Satya and I have to maintain it for years in downstream kernels anyway, so > it will be used and tested regardless. It would also be nice to allow userspace > (e.g. xfstests) to assume that if the inlinecrypt mount option is supported, > then direct I/O is supported too, without having to handle intermediate kernel > releases where inlinecrypt was supported but not direct I/O. > As Eric pointed out, it doesn't seem to be completely straightforward to move f2fs to using iomap - I'm still looking into it, but for now I've sent out v2 (and v3 just because I forgot to add a changelog to v2) with the changes to fs/direct-io.c as is from v1, but (again, for the reasons Eric points out) I think it'd be better not to hold this patch up for that. > - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel