From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B02FC433E1 for ; Sun, 19 Jul 2020 15:16:54 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E84A322B4D; Sun, 19 Jul 2020 15:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="j8KPIGA5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="GdJNBRvy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bDBYRNpm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E84A322B4D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jxB3b-00085o-N3; Sun, 19 Jul 2020 15:16:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxB3Z-00085T-Pe for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Jul 2020 15:16:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=f+/nMC9KtprnGJTYsDKdWMQCSAEu8qFX2gEgq1WTZAo=; b=j8KPIGA55cEq6Ic71bYHO+aAvC Kg3gSfEF/9NxSccVmepjmtmTOl5EC9oZQE0KMzqytqNeKax+J4I3e3uVKycunYJoHjNzcb+txcLCO 4ZVzWhgYRMUgnmzlOSohqBg6NYgTHJbn+xeaZ+C5WblglY7KDn2MFMuQlNOPUal8e514=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f+/nMC9KtprnGJTYsDKdWMQCSAEu8qFX2gEgq1WTZAo=; b=GdJNBRvyEjBBVcPbw9j08frxNW kLxPPTJ6J/orq+Yj1ymqgmFuprh7cSmyxWU6h7XIQRHB4eMyhYepVLwGE2QSTsnidUoh7VWqGv+KR IO9NI2Joj9LNkKQ6mqvi4pVRusjZAtqDJLeDYe3FZKuwPs11RUi7OL41xQ1yDYoroLy0=; Received: from [198.145.29.99] (helo=mail.kernel.org) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jxB3T-00FkSv-Tr for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Jul 2020 15:16:49 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F344422B4D; Sun, 19 Jul 2020 15:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595171788; bh=bUHUr8f704qfasOHLj7vXLRRYUwyFmxfe3IyM5uTxcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bDBYRNpmL2M5sfmkgiJWS3XCx5IzAXxr0VWlgyZtoZGe2ptUpbQyPKuXtyCiCUq3M 2L0PJLwBReVvJjL9W7ykO7KHA77DAfN9b8wyEczaC5hOTi9WwPJhjaSV/wqZfN4Bpl TX5cv/URXmkSyvc/1cJg/VpmESwM+Ko6qhdqvfl0= Date: Sun, 19 Jul 2020 17:16:40 +0200 From: Greg KH To: Daeho Jeong Message-ID: <20200719151640.GA301791@kroah.com> References: <20200719054409.3050516-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200719054409.3050516-1-daeho43@gmail.com> X-Headers-End: 1jxB3T-00FkSv-Tr Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link directory pointing to its device name > directory using the volume name of the partition in sysfs. > (i.e., /sys/fs/f2fs/vol_#x -> /sys/fs/f2fs/sda1) No, please no. That is already created today for you in /dev/disk/ The kernel does not need to do this again. If your distro/system/whatever does not provide you with /dev/disk/ and all of the symlinks in there, then work with your distro/system/whatever to do so. Again, no need to do this on a per-filesystem-basis when we already have this around for all filesystems, and have had it for 15+ years now. thanks, greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel