Linux-f2fs-devel Archive on lore.kernel.org
 help / color / Atom feed
* Re: [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
       [not found] <202007211524.zrSvup2X%lkp@intel.com>
@ 2020-07-21 13:42 ` Aravind Ramesh
  2020-07-21 19:57   ` Jaegeuk Kim
  0 siblings, 1 reply; 4+ messages in thread
From: Aravind Ramesh @ 2020-07-21 13:42 UTC (permalink / raw)
  To: Jaegeuk Kim
  Cc: Niklas Cassel, Damien Le Moal, kbuild-all, kernel test robot,
	linux-f2fs-devel

Hello Jaegeuk,
The patch that adds the capacity struct member has been merged to linux-block tree's for-next branch.
So either:
1. f2fs-dev branch has to carry the same patch, from here:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/include/uapi/linux/blkzoned.h?h=for-next
I had mentioned this is the cover letter of this patch.
2. linux-block pull request has to be merged before f2fs pull request to Linus
3. Or this f2fs patch has to wait until next merge window (the one after kernel 5.9 merge window)

Thanks
Aravind

> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Tuesday, July 21, 2020 12:43 PM
> To: Aravind Ramesh <Aravind.Ramesh@wdc.com>
> Cc: kbuild-all@lists.01.org; linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim
> <jaegeuk@kernel.org>; Damien Le Moal <Damien.LeMoal@wdc.com>; Niklas Cassel
> <Niklas.Cassel@wdc.com>; Chao Yu <yuchao0@huawei.com>; Chao Yu
> <chao@kernel.org>
> Subject: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has
> no member named 'capacity'
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> head:   439633ba3673a5d8983529426df144c64a23d181
> commit: d787c5eec8b58bb47d4bf750758e0e87d667bf56 [37/38] f2fs: support
> zone capacity less than zone size
> config: nds32-allyesconfig (attached as .config)
> compiler: nds32le-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-
> tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d787c5eec8b58bb47d4bf750758e0e87d667bf56
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> ARCH=nds32
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    fs/f2fs/super.c: In function 'f2fs_report_zone_cb':
> >> fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
>     3058 |  rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
>          |                                                ^~
>    fs/f2fs/super.c:3060:23: error: 'struct blk_zone' has no member named 'capacity'
>     3060 |  if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
>          |                       ^~
> 
> vim +3058 fs/f2fs/super.c
> 
>   3048
>   3049	static int f2fs_report_zone_cb(struct blk_zone *zone, unsigned int idx,
>   3050				      void *data)
>   3051	{
>   3052		struct f2fs_report_zones_args *rz_args = data;
>   3053
>   3054		if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
>   3055			return 0;
>   3056
>   3057		set_bit(idx, rz_args->dev->blkz_seq);
> > 3058		rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
>   3059
> 	F2FS_LOG_SECTORS_PER_BLOCK;
>   3060		if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
>   3061			rz_args->zone_cap_mismatch = true;
>   3062
>   3063		return 0;
>   3064	}
>   3065
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
  2020-07-21 13:42 ` [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity' Aravind Ramesh
@ 2020-07-21 19:57   ` Jaegeuk Kim
  2020-08-10 14:18     ` Niklas Cassel
  0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2020-07-21 19:57 UTC (permalink / raw)
  To: Aravind Ramesh
  Cc: Niklas Cassel, Damien Le Moal, kbuild-all, kernel test robot,
	linux-f2fs-devel

On 07/21, Aravind Ramesh wrote:
> Hello Jaegeuk,
> The patch that adds the capacity struct member has been merged to linux-block tree's for-next branch.
> So either:
> 1. f2fs-dev branch has to carry the same patch, from here:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/include/uapi/linux/blkzoned.h?h=for-next
> I had mentioned this is the cover letter of this patch.
> 2. linux-block pull request has to be merged before f2fs pull request to Linus
> 3. Or this f2fs patch has to wait until next merge window (the one after kernel 5.9 merge window)

Yeah, indeed. Let me queue this patch and try upstream later till block has it.

Thanks,

> 
> Thanks
> Aravind
> 
> > -----Original Message-----
> > From: kernel test robot <lkp@intel.com>
> > Sent: Tuesday, July 21, 2020 12:43 PM
> > To: Aravind Ramesh <Aravind.Ramesh@wdc.com>
> > Cc: kbuild-all@lists.01.org; linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim
> > <jaegeuk@kernel.org>; Damien Le Moal <Damien.LeMoal@wdc.com>; Niklas Cassel
> > <Niklas.Cassel@wdc.com>; Chao Yu <yuchao0@huawei.com>; Chao Yu
> > <chao@kernel.org>
> > Subject: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has
> > no member named 'capacity'
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> > head:   439633ba3673a5d8983529426df144c64a23d181
> > commit: d787c5eec8b58bb47d4bf750758e0e87d667bf56 [37/38] f2fs: support
> > zone capacity less than zone size
> > config: nds32-allyesconfig (attached as .config)
> > compiler: nds32le-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-
> > tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout d787c5eec8b58bb47d4bf750758e0e87d667bf56
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> > ARCH=nds32
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    fs/f2fs/super.c: In function 'f2fs_report_zone_cb':
> > >> fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
> >     3058 |  rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> >          |                                                ^~
> >    fs/f2fs/super.c:3060:23: error: 'struct blk_zone' has no member named 'capacity'
> >     3060 |  if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> >          |                       ^~
> > 
> > vim +3058 fs/f2fs/super.c
> > 
> >   3048
> >   3049	static int f2fs_report_zone_cb(struct blk_zone *zone, unsigned int idx,
> >   3050				      void *data)
> >   3051	{
> >   3052		struct f2fs_report_zones_args *rz_args = data;
> >   3053
> >   3054		if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
> >   3055			return 0;
> >   3056
> >   3057		set_bit(idx, rz_args->dev->blkz_seq);
> > > 3058		rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> >   3059
> > 	F2FS_LOG_SECTORS_PER_BLOCK;
> >   3060		if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> >   3061			rz_args->zone_cap_mismatch = true;
> >   3062
> >   3063		return 0;
> >   3064	}
> >   3065
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
  2020-07-21 19:57   ` Jaegeuk Kim
@ 2020-08-10 14:18     ` Niklas Cassel
  2020-08-10 19:49       ` Jaegeuk Kim
  0 siblings, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2020-08-10 14:18 UTC (permalink / raw)
  To: Jaegeuk Kim
  Cc: Damien Le Moal, kbuild-all, kernel test robot, Aravind Ramesh,
	linux-f2fs-devel, Hans Holmberg

On Tue, Jul 21, 2020 at 12:57:36PM -0700, Jaegeuk Kim wrote:
> On 07/21, Aravind Ramesh wrote:
> > Hello Jaegeuk,
> > The patch that adds the capacity struct member has been merged to linux-block tree's for-next branch.
> > So either:
> > 1. f2fs-dev branch has to carry the same patch, from here:
> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/include/uapi/linux/blkzoned.h?h=for-next
> > I had mentioned this is the cover letter of this patch.
> > 2. linux-block pull request has to be merged before f2fs pull request to Linus
> > 3. Or this f2fs patch has to wait until next merge window (the one after kernel 5.9 merge window)
> 
> Yeah, indeed. Let me queue this patch and try upstream later till block has it.

Hello Jaegeuk,

Just curious, where is this queued?

I can't find it on any of your branches on this git:
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git

FWIW, commit 82394db7383d ("block: add capacity field to zone descriptors")
is now in Torvald's tree.

Which merge window did you intend for this patch? 5.9 or 5.10?


Kind regards,
Niklas

> 
> Thanks,
> 
> > 
> > Thanks
> > Aravind
> > 
> > > -----Original Message-----
> > > From: kernel test robot <lkp@intel.com>
> > > Sent: Tuesday, July 21, 2020 12:43 PM
> > > To: Aravind Ramesh <Aravind.Ramesh@wdc.com>
> > > Cc: kbuild-all@lists.01.org; linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim
> > > <jaegeuk@kernel.org>; Damien Le Moal <Damien.LeMoal@wdc.com>; Niklas Cassel
> > > <Niklas.Cassel@wdc.com>; Chao Yu <yuchao0@huawei.com>; Chao Yu
> > > <chao@kernel.org>
> > > Subject: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has
> > > no member named 'capacity'
> > > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> > > head:   439633ba3673a5d8983529426df144c64a23d181
> > > commit: d787c5eec8b58bb47d4bf750758e0e87d667bf56 [37/38] f2fs: support
> > > zone capacity less than zone size
> > > config: nds32-allyesconfig (attached as .config)
> > > compiler: nds32le-linux-gcc (GCC) 9.3.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-
> > > tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         git checkout d787c5eec8b58bb47d4bf750758e0e87d667bf56
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> > > ARCH=nds32
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    fs/f2fs/super.c: In function 'f2fs_report_zone_cb':
> > > >> fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
> > >     3058 |  rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> > >          |                                                ^~
> > >    fs/f2fs/super.c:3060:23: error: 'struct blk_zone' has no member named 'capacity'
> > >     3060 |  if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> > >          |                       ^~
> > > 
> > > vim +3058 fs/f2fs/super.c
> > > 
> > >   3048
> > >   3049	static int f2fs_report_zone_cb(struct blk_zone *zone, unsigned int idx,
> > >   3050				      void *data)
> > >   3051	{
> > >   3052		struct f2fs_report_zones_args *rz_args = data;
> > >   3053
> > >   3054		if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
> > >   3055			return 0;
> > >   3056
> > >   3057		set_bit(idx, rz_args->dev->blkz_seq);
> > > > 3058		rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> > >   3059
> > > 	F2FS_LOG_SECTORS_PER_BLOCK;
> > >   3060		if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> > >   3061			rz_args->zone_cap_mismatch = true;
> > >   3062
> > >   3063		return 0;
> > >   3064	}
> > >   3065
> > > 
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
  2020-08-10 14:18     ` Niklas Cassel
@ 2020-08-10 19:49       ` Jaegeuk Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2020-08-10 19:49 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Damien Le Moal, kbuild-all, kernel test robot, Aravind Ramesh,
	linux-f2fs-devel, Hans Holmberg

On 08/10, Niklas Cassel wrote:
> On Tue, Jul 21, 2020 at 12:57:36PM -0700, Jaegeuk Kim wrote:
> > On 07/21, Aravind Ramesh wrote:
> > > Hello Jaegeuk,
> > > The patch that adds the capacity struct member has been merged to linux-block tree's for-next branch.
> > > So either:
> > > 1. f2fs-dev branch has to carry the same patch, from here:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/include/uapi/linux/blkzoned.h?h=for-next
> > > I had mentioned this is the cover letter of this patch.
> > > 2. linux-block pull request has to be merged before f2fs pull request to Linus
> > > 3. Or this f2fs patch has to wait until next merge window (the one after kernel 5.9 merge window)
> > 
> > Yeah, indeed. Let me queue this patch and try upstream later till block has it.
> 
> Hello Jaegeuk,
> 
> Just curious, where is this queued?
> 
> I can't find it on any of your branches on this git:
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git
> 
> FWIW, commit 82394db7383d ("block: add capacity field to zone descriptors")
> is now in Torvald's tree.
> 
> Which merge window did you intend for this patch? 5.9 or 5.10?

It was in https://github.com/jaegeuk/f2fs/commit/550451dc977aeb0000104eb9777fd1dca07e5efb,
and will be moved into kernel.org once pull request for 4.9 was applied.
I think we can merge it in 5.10.

Thanks,

> 
> 
> Kind regards,
> Niklas
> 
> > 
> > Thanks,
> > 
> > > 
> > > Thanks
> > > Aravind
> > > 
> > > > -----Original Message-----
> > > > From: kernel test robot <lkp@intel.com>
> > > > Sent: Tuesday, July 21, 2020 12:43 PM
> > > > To: Aravind Ramesh <Aravind.Ramesh@wdc.com>
> > > > Cc: kbuild-all@lists.01.org; linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim
> > > > <jaegeuk@kernel.org>; Damien Le Moal <Damien.LeMoal@wdc.com>; Niklas Cassel
> > > > <Niklas.Cassel@wdc.com>; Chao Yu <yuchao0@huawei.com>; Chao Yu
> > > > <chao@kernel.org>
> > > > Subject: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has
> > > > no member named 'capacity'
> > > > 
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> > > > head:   439633ba3673a5d8983529426df144c64a23d181
> > > > commit: d787c5eec8b58bb47d4bf750758e0e87d667bf56 [37/38] f2fs: support
> > > > zone capacity less than zone size
> > > > config: nds32-allyesconfig (attached as .config)
> > > > compiler: nds32le-linux-gcc (GCC) 9.3.0
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-
> > > > tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         git checkout d787c5eec8b58bb47d4bf750758e0e87d667bf56
> > > >         # save the attached .config to linux build tree
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> > > > ARCH=nds32
> > > > 
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > >    fs/f2fs/super.c: In function 'f2fs_report_zone_cb':
> > > > >> fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'
> > > >     3058 |  rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> > > >          |                                                ^~
> > > >    fs/f2fs/super.c:3060:23: error: 'struct blk_zone' has no member named 'capacity'
> > > >     3060 |  if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> > > >          |                       ^~
> > > > 
> > > > vim +3058 fs/f2fs/super.c
> > > > 
> > > >   3048
> > > >   3049	static int f2fs_report_zone_cb(struct blk_zone *zone, unsigned int idx,
> > > >   3050				      void *data)
> > > >   3051	{
> > > >   3052		struct f2fs_report_zones_args *rz_args = data;
> > > >   3053
> > > >   3054		if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
> > > >   3055			return 0;
> > > >   3056
> > > >   3057		set_bit(idx, rz_args->dev->blkz_seq);
> > > > > 3058		rz_args->dev->zone_capacity_blocks[idx] = zone->capacity >>
> > > >   3059
> > > > 	F2FS_LOG_SECTORS_PER_BLOCK;
> > > >   3060		if (zone->len != zone->capacity && !rz_args->zone_cap_mismatch)
> > > >   3061			rz_args->zone_cap_mismatch = true;
> > > >   3062
> > > >   3063		return 0;
> > > >   3064	}
> > > >   3065
> > > > 
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <202007211524.zrSvup2X%lkp@intel.com>
2020-07-21 13:42 ` [f2fs-dev] [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity' Aravind Ramesh
2020-07-21 19:57   ` Jaegeuk Kim
2020-08-10 14:18     ` Niklas Cassel
2020-08-10 19:49       ` Jaegeuk Kim

Linux-f2fs-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-f2fs-devel/0 linux-f2fs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-f2fs-devel linux-f2fs-devel/ https://lore.kernel.org/linux-f2fs-devel \
		linux-f2fs-devel@lists.sourceforge.net
	public-inbox-index linux-f2fs-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/net.sourceforge.lists.linux-f2fs-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git