From: Dan Robertson <dan@dlrobertson.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: Dan Robertson <dan@dlrobertson.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH v3 0/1] f2fs: check position in move range ioctl
Date: Sun, 30 Aug 2020 21:45:22 +0000 [thread overview]
Message-ID: <20200830214523.7417-1-dan@dlrobertson.com> (raw)
Changes in v3:
- Check the input position as well as the output position.
Changes in v2:
- Moved check of output position before we lock the source or
destination inode.
If a negative value is provided as the output position to the
F2FS_IOC_MOVE_RANGE ioctl, f2fs_get_dnode_of_data may hit a memory
bug like the following:
BUG: unable to handle page fault for address: ffffed10b30435a4
[...]
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009) ...
[...]
Call Trace:
f2fs_get_dnode_of_data+0xa68/0xde0
[...]
f2fs_reserve_block+0x3b/0x230
f2fs_get_new_data_page+0xf0/0x8b0
? f2fs_get_lock_data_page+0x1f0/0x1f0
? rwsem_down_write_slowpath+0x8d0/0x8d0
? rwsem_down_read_slowpath+0x830/0x830
? ___might_sleep+0xba/0xd0
? f2fs_get_lock_data_page+0x17a/0x1f0
__exchange_data_block+0x11bf/0x24d0
? f2fs_ioc_release_volatile_write+0x170/0x170
? __might_sleep+0x31/0xd0
? ___might_sleep+0xba/0xd0
? rwsem_down_read_slowpath+0x830/0x830
? __init_rwsem+0xa0/0xa0
f2fs_ioctl+0x469c/0x6980
Dan Robertson (1):
f2fs: check position in move range ioctl
fs/f2fs/file.c | 3 +++
1 file changed, 3 insertions(+)
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2020-08-30 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 21:45 Dan Robertson [this message]
2020-08-30 21:45 ` [f2fs-dev] [PATCH v3 1/1] f2fs: check position in move range ioctl Dan Robertson
2020-08-31 0:56 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830214523.7417-1-dan@dlrobertson.com \
--to=dan@dlrobertson.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).