* [f2fs-dev] [PATCH] f2fs: remove unused check on version_bitmap
@ 2020-09-19 3:35 Wang Xiaojun
2020-09-19 7:24 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Wang Xiaojun @ 2020-09-19 3:35 UTC (permalink / raw)
To: yuchao0, jaegeuk; +Cc: linux-f2fs-devel
A NULL will not be return by __bitmap_ptr here.
Remove the unused check.
Signed-off-by: Wang Xiaojun <wangxiaojun11@huawei.com>
---
fs/f2fs/node.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index cb1b5b61a1da..2cf11662f784 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -3105,9 +3105,6 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
nm_i->next_scan_nid = le32_to_cpu(sbi->ckpt->next_free_nid);
nm_i->bitmap_size = __bitmap_size(sbi, NAT_BITMAP);
version_bitmap = __bitmap_ptr(sbi, NAT_BITMAP);
- if (!version_bitmap)
- return -EFAULT;
-
nm_i->nat_bitmap = kmemdup(version_bitmap, nm_i->bitmap_size,
GFP_KERNEL);
if (!nm_i->nat_bitmap)
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unused check on version_bitmap
2020-09-19 3:35 [f2fs-dev] [PATCH] f2fs: remove unused check on version_bitmap Wang Xiaojun
@ 2020-09-19 7:24 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-09-19 7:24 UTC (permalink / raw)
To: Wang Xiaojun, jaegeuk; +Cc: linux-f2fs-devel
On 2020/9/19 11:35, Wang Xiaojun wrote:
> A NULL will not be return by __bitmap_ptr here.
> Remove the unused check.
>
> Signed-off-by: Wang Xiaojun <wangxiaojun11@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-19 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 3:35 [f2fs-dev] [PATCH] f2fs: remove unused check on version_bitmap Wang Xiaojun
2020-09-19 7:24 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).