From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E79C4346E for ; Mon, 21 Sep 2020 18:30:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2261A20758 for ; Mon, 21 Sep 2020 18:30:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="ZU74mj/r"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="bUeULoDu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eeL3T5WA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2261A20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kKQZj-0001ij-RL; Mon, 21 Sep 2020 18:30:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKQZi-0001iU-Jz for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 Sep 2020 18:30:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+3oLhdr8w+XAMAcjdV9Rr25rnzs8e4/4Eqnd3yjHUug=; b=ZU74mj/r3dp0FcPUcbVbAzltGw eOqA5fBXqGpBcYtaaqLS/Slahlif7PfQLj+Ud4nWfIFAAaaIU1/OqLi/J1z97NG52WXtfnXSJjRrJ v/8GdyKAkB+HJhchDtQ/AA0KK9QhIGYuxOU3VAuU+bE68OhLOIp3fqozLlddHsQmwg2A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+3oLhdr8w+XAMAcjdV9Rr25rnzs8e4/4Eqnd3yjHUug=; b=bUeULoDuxOgibJATCmoNbFliwp pB7MI0vinnCpE1a0qUEpH2n/N5UjRdCrdEsXSx/Q1WnAlBdxnVWT6KRAiCdGHfzQ/RUtgE9awmxYe /+9AnvJbiz6tBO7ex4ueMS+NOkoHKbXOAivt2d3obI3R4TPf3SNgY9Omb0TV2/ie2mtU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kKQZX-002IRM-MK for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 Sep 2020 18:30:06 +0000 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC2A220758; Mon, 21 Sep 2020 18:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600712990; bh=xfKd1sWDGNhVdepPEKC1RdDT0tu6IQ/iGDe1bIAhKWE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eeL3T5WAha4l7IADwnyUubjJZSCetFw5JMJ+kxtH/TvUthibhmb+DvBnGmWcChcbt iE30z75SNSivfly/Ae3pYKjc5xglPEaExNgz/vjPN/BEKGQ2BYDU8wDgNsNkKBn1Cm QSWUJ0N/kinYBsYwIrCEsanyApVuhkGpI+Dtzz9Y= Date: Mon, 21 Sep 2020 11:29:48 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Message-ID: <20200921182948.GA885472@gmail.com> References: <20200708091237.3922153-1-drosen@google.com> <20200708091237.3922153-5-drosen@google.com> <87lfh4djdq.fsf@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lfh4djdq.fsf@collabora.com> X-Headers-End: 1kKQZX-002IRM-MK Subject: Re: [f2fs-dev] [PATCH v12 4/4] ext4: Use generic casefolding support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Daniel Rosenberg , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Sep 20, 2020 at 09:10:57PM -0400, Gabriel Krisman Bertazi wrote: > Daniel Rosenberg writes: > > > This switches ext4 over to the generic support provided in > > the previous patch. > > > > Since casefolded dentries behave the same in ext4 and f2fs, we decrease > > the maintenance burden by unifying them, and any optimizations will > > immediately apply to both. > > > > Signed-off-by: Daniel Rosenberg > > Reviewed-by: Eric Biggers > > > > #ifdef CONFIG_UNICODE > > - if (EXT4_SB(parent->i_sb)->s_encoding && IS_CASEFOLDED(parent)) { > > + if (parent->i_sb->s_encoding && IS_CASEFOLDED(parent)) { > > if (fname->cf_name.name) { > > struct qstr cf = {.name = fname->cf_name.name, > > .len = fname->cf_name.len}; > > @@ -2171,9 +2171,6 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, > > struct buffer_head *bh = NULL; > > struct ext4_dir_entry_2 *de; > > struct super_block *sb; > > -#ifdef CONFIG_UNICODE > > - struct ext4_sb_info *sbi; > > -#endif > > struct ext4_filename fname; > > int retval; > > int dx_fallback=0; > > @@ -2190,9 +2187,8 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, > > return -EINVAL; > > > > #ifdef CONFIG_UNICODE > > - sbi = EXT4_SB(sb); > > - if (ext4_has_strict_mode(sbi) && IS_CASEFOLDED(dir) && > > - sbi->s_encoding && utf8_validate(sbi->s_encoding, &dentry->d_name)) > > + if (sb_has_strict_encoding(sb) && IS_CASEFOLDED(dir) && > > + sb->s_encoding && utf8_validate(sb->s_encoding, &dentry->d_name)) > > return -EINVAL; > > hm, just noticed the sb->s_encoding check here is superfluous, since the > has_strict_mode() cannot be true if !s_encoding. Not related to this > patch though. > > Daniel, are you still working on getting this upstream? The fscrypt > support would be very useful for us. :) > > In the hope this will get upstream, as its been flying for a while and > looks correct. > > Reviewed-by: Gabriel Krisman Bertazi We couldn't get a response from Ted, so instead Jaegeuk has applied patches 1-3 to f2fs/dev for 5.10. Hopefully Ted will take the ext4 patch for 5.11. I believe that Daniel is planning to resend the actual encryption+casefolding support soon, but initially only for f2fs since that will be ready first. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel