From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D929BC433EF for ; Sun, 15 May 2022 11:17:28 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nqCFb-00017P-6s; Sun, 15 May 2022 11:17:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqCFa-00017J-EI for linux-f2fs-devel@lists.sourceforge.net; Sun, 15 May 2022 11:17:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ley37C+FLIOrNacG/8nrnabLLLolHRUsN5D6Ad3KsiQ=; b=II8mNyzt+azCwtTzL2AbRighNy Wjb8aaP3T1bKVM0FqTUlH7mQNrCjUsxpiswb9YrHvBlG2T30otceU+Y5pzoOq/T2hSXdj0fJIqfbH OcS5OchFx1TNfxL0bbHlZAtzduBOvS4X/W+UWXkH3wnwaklZ2iHNaRQF2e0ahyBD+Ovk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ley37C+FLIOrNacG/8nrnabLLLolHRUsN5D6Ad3KsiQ=; b=Q hTedq0BDnS79rFsfJ4BEq35ZPLzJRZV9bQMiGzhxDPdpATxx3ilIa/SgGR6qrVQl6JL9j7OQGJbU3 EHMlQ5NzhMcNfDxo/9M7AT6hCdjMXPJa0O+4sl3EerTmrpYe9ldadN+mbklazfVYfFrrusp0Ayngs +7TkcOkh/hd2GfMk=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nqCFV-00Ecbi-5R for linux-f2fs-devel@lists.sourceforge.net; Sun, 15 May 2022 11:17:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA64E60F4C; Sun, 15 May 2022 11:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66B4AC385B8; Sun, 15 May 2022 11:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652613430; bh=d0TL17vMLRIGLh71PguP2wy7GGGqSL/xy2fQvHsvOL8=; h=From:To:Cc:Subject:Date:From; b=GrxZnQJi8vwlTzhfuxKigVFdkojTW2WthcuhEjXg/rKT5DICe8fYB8XsJSBQQTfI+ MeEFoOv1vX6QEoBfYMJVYdNeELfOQlrEb3aI5F+mYAkxC1+TWt6oRuAy3cHk9Ckcjq bJ//p5emIVWUV+IF2sFSXQu5I2o9BamNlTdYpkfCzmYRz0uVYrI+uot0e40yhNaajY n6JW1ipf1+iI4l76ol3h7R4UuFBIR5gt7q8XzHYPPaRgoVTYh+k9YFAHPbpcdHqEBS LHk5BX2Rh9AKUFSri2SIYAsImfU8qxpFqLeEqMwK7R1lp9Galn/jkmv4eus6WoZMBl 1uEcdAlwtcTdw== From: Chao Yu To: jaegeuk@kernel.org Date: Sun, 15 May 2022 18:39:34 +0800 Message-Id: <20220515103934.5306-1-chao@kernel.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Headers-End: 1nqCFV-00Ecbi-5R Subject: [f2fs-dev] [PATCH v2] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Pinning a file is heavy, because skipping pinned files make GC running with heavy load or no effect. So that this patch proposes to separate nocow and pinfile semantics: - NOCoW flag can only be set on regular file. - NOCoW file will only trigger IPU at common writeback/flush. - NOCow file will do OPU during GC. This flag can satisfying the demand of: 1) avoiding fragment of file's physical block 2) userspace doesn't want to pin file's physical address After commit 5d539245cb18 ("f2fs: export FS_NOCOW_FL flag to user"), Pin_file and NOCoW flags have already been twined closely. e.g. once we set pinfile flag in file, nocow flag will be shown; and after clearing pinfile flag, nocow flag will disappear. So, in order to keep backward compatibility, let use below semantics: f2fs_ioc_set_pin_file/f2fs_fileattr_set logic: pinfile nocow set set pinfile | nocow set nocow clear clear pinfile | nocow clear nocow File Behaviors: w/ pinfile, w/ nocow: use pinfile semantics w/ pinfile, w/o nocow: use pinfile semantics w/o pinfile, w/ nocow: use nocow semantics w/o pinfile, w/o nocow: no pinfile or nocow semantics Signed-off-by: Chao Yu --- v2: - keep compatibility in between pinfile and nocow flags fs/f2fs/data.c | 3 ++- fs/f2fs/f2fs.h | 8 +++++++- fs/f2fs/file.c | 16 +++++++++++++++- 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 54a7a8ad994d..c8eab78f7d89 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2495,7 +2495,8 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) if (is_inode_flag_set(inode, FI_ALIGNED_WRITE)) return false; - if (f2fs_is_pinned_file(inode)) + if (f2fs_is_pinned_file(inode) || + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) return true; /* if this is cold file, we should overwrite to avoid fragmentation */ diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 18a0335799ad..d9445fc62bd7 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2929,6 +2929,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ @@ -2965,9 +2966,14 @@ static inline void __mark_inode_dirty_flag(struct inode *inode, if (set) return; fallthrough; + case FI_PIN_FILE: + if (set) + F2FS_I(inode)->i_flags |= F2FS_NOCOW_FL; + else + F2FS_I(inode)->i_flags &= ~F2FS_NOCOW_FL; + fallthrough; case FI_DATA_EXIST: case FI_INLINE_DOTS: - case FI_PIN_FILE: case FI_COMPRESS_RELEASED: f2fs_mark_inode_dirty_sync(inode, true); } diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index b857384ccd12..da635a904e69 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1854,6 +1854,18 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) if (IS_NOQUOTA(inode)) return -EPERM; + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { + int ret; + + if (!S_ISREG(inode->i_mode)) + return -EINVAL; + if (f2fs_should_update_outplace(inode, NULL)) + return -EINVAL; + ret = f2fs_convert_inline_inode(inode); + if (ret) + return ret; + } + if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) return -EOPNOTSUPP; @@ -1929,6 +1941,7 @@ static const struct { { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, { F2FS_INDEX_FL, FS_INDEX_FL }, { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, + { F2FS_NOCOW_FL, FS_NOCOW_FL }, { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, }; @@ -1960,7 +1973,8 @@ static const struct { FS_NOCOMP_FL | \ FS_DIRSYNC_FL | \ FS_PROJINHERIT_FL | \ - FS_CASEFOLD_FL) + FS_CASEFOLD_FL | \ + FS_NOCOW_FL) /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ static inline u32 f2fs_iflags_to_fsflags(u32 iflags) -- 2.32.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel