linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Douglas RAILLARD <douglas.raillard@arm.com>
Cc: "open list:TRACING" <linux-kernel@vger.kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	"open list:TRACING" <linux-trace-kernel@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event
Date: Mon, 6 Mar 2023 11:15:13 -0500	[thread overview]
Message-ID: <20230306111513.2aa49b1a@gandalf.local.home> (raw)
In-Reply-To: <20230306122549.236561-1-douglas.raillard@arm.com>

On Mon,  6 Mar 2023 12:25:49 +0000
Douglas RAILLARD <douglas.raillard@arm.com> wrote:

> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index 31d994e6b4ca..8d053838d6cf 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -512,7 +512,7 @@ TRACE_EVENT(f2fs_truncate_partial_nodes,
>  	TP_STRUCT__entry(
>  		__field(dev_t,	dev)
>  		__field(ino_t,	ino)
> -		__field(nid_t,	nid[3])

That should not have even compiled. I'll see if I can add some tricks to
make that fail.

Thanks,

-- Steve


> +		__array(nid_t,	nid, 3)
>  		__field(int,	depth)
>  		__field(int,	err)
>  	),


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2023-03-06 16:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 12:25 [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event Douglas RAILLARD
2023-03-06 12:51 ` Mukesh Ojha
2023-03-06 16:15 ` Steven Rostedt [this message]
2023-03-06 17:25   ` Steven Rostedt
2023-03-07  6:01 ` Chao Yu
2023-03-07 17:40 ` patchwork-bot+f2fs
2023-03-28 23:03   ` Steven Rostedt
2023-03-29  0:36     ` Jaegeuk Kim
2023-03-29  1:01       ` Steven Rostedt
2023-03-29 17:41       ` Linus Torvalds
2023-08-14 13:32 ` Kajetan Puchalski
2023-08-14 14:39   ` Kajetan Puchalski
2023-08-14 20:37     ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306111513.2aa49b1a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=douglas.raillard@arm.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).