From: Daeho Jeong <daeho43@gmail.com>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: [f2fs-dev] [PATCH] f2fs-tools: fix wrong write pointer check for non-zoned areas
Date: Tue, 6 Jun 2023 10:39:48 -0700 [thread overview]
Message-ID: <20230606173948.3390215-1-daeho43@gmail.com> (raw)
From: Daeho Jeong <daehojeong@google.com>
Do not check F2FS_ZONED_HM for the whole device. We need to do this for
each area of devices.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
fsck/mount.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fsck/mount.c b/fsck/mount.c
index 851a62b..0ebbfcf 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -2868,9 +2868,6 @@ static bool write_pointer_at_zone_start(struct f2fs_sb_info *sbi,
int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT;
int ret, j;
- if (c.zoned_model != F2FS_ZONED_HM)
- return true;
-
for (j = 0; j < MAX_DEVICES; j++) {
if (!c.devices[j].path)
break;
@@ -2882,6 +2879,9 @@ static bool write_pointer_at_zone_start(struct f2fs_sb_info *sbi,
if (j >= MAX_DEVICES)
return false;
+ if (c.devices[j].zoned_model != F2FS_ZONED_HM)
+ return true;
+
sector = (block - c.devices[j].start_blkaddr) << log_sectors_per_block;
ret = f2fs_report_zone(j, sector, &blkz);
if (ret)
--
2.41.0.rc0.172.g3f132b7071-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2023-06-06 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 17:39 Daeho Jeong [this message]
2023-06-08 10:11 ` [f2fs-dev] [PATCH] f2fs-tools: fix wrong write pointer check for non-zoned areas Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606173948.3390215-1-daeho43@gmail.com \
--to=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).