From: kernel test robot <lkp@intel.com>
To: Gabriel Krisman Bertazi <krisman@suse.de>,
viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
ebiggers@kernel.org, jaegeuk@kernel.org
Cc: Gabriel Krisman Bertazi <krisman@suse.de>,
llvm@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net,
oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v5 04/10] fs: Expose name under lookup to d_revalidate hooks
Date: Thu, 17 Aug 2023 17:12:58 +0800 [thread overview]
Message-ID: <202308171740.0u9DuWtr-lkp@intel.com> (raw)
In-Reply-To: <20230812004146.30980-5-krisman@suse.de>
Hi Gabriel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on linus/master]
[cannot apply to tyhicks-ecryptfs/next ericvh-v9fs/for-next viro-vfs/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/fs-Expose-helper-to-check-if-a-directory-needs-casefolding/20230812-084506
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link: https://lore.kernel.org/r/20230812004146.30980-5-krisman%40suse.de
patch subject: [PATCH v5 04/10] fs: Expose name under lookup to d_revalidate hooks
config: x86_64-randconfig-x012-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171740.0u9DuWtr-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171740.0u9DuWtr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171740.0u9DuWtr-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ecryptfs/dentry.c:33: warning: Function parameter or member 'name' not described in 'ecryptfs_d_revalidate'
vim +33 fs/ecryptfs/dentry.c
237fead619984c Michael Halcrow 2006-10-04 17
237fead619984c Michael Halcrow 2006-10-04 18 /**
237fead619984c Michael Halcrow 2006-10-04 19 * ecryptfs_d_revalidate - revalidate an ecryptfs dentry
237fead619984c Michael Halcrow 2006-10-04 20 * @dentry: The ecryptfs dentry
0b728e1911cbe6 Al Viro 2012-06-10 21 * @flags: lookup flags
237fead619984c Michael Halcrow 2006-10-04 22 *
237fead619984c Michael Halcrow 2006-10-04 23 * Called when the VFS needs to revalidate a dentry. This
237fead619984c Michael Halcrow 2006-10-04 24 * is called whenever a name lookup finds a dentry in the
237fead619984c Michael Halcrow 2006-10-04 25 * dcache. Most filesystems leave this as NULL, because all their
237fead619984c Michael Halcrow 2006-10-04 26 * dentries in the dcache are valid.
237fead619984c Michael Halcrow 2006-10-04 27 *
237fead619984c Michael Halcrow 2006-10-04 28 * Returns 1 if valid, 0 otherwise.
237fead619984c Michael Halcrow 2006-10-04 29 *
237fead619984c Michael Halcrow 2006-10-04 30 */
0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 31 static int ecryptfs_d_revalidate(struct dentry *dentry,
0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 32 const struct qstr *name, unsigned int flags)
237fead619984c Michael Halcrow 2006-10-04 @33 {
2edbfbf1c1ab0a Al Viro 2013-09-15 34 struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
5556e7e6d30e8e Tyler Hicks 2015-08-05 35 int rc = 1;
237fead619984c Michael Halcrow 2006-10-04 36
0b728e1911cbe6 Al Viro 2012-06-10 37 if (flags & LOOKUP_RCU)
34286d6662308d Nicholas Piggin 2011-01-07 38 return -ECHILD;
34286d6662308d Nicholas Piggin 2011-01-07 39
5556e7e6d30e8e Tyler Hicks 2015-08-05 40 if (lower_dentry->d_flags & DCACHE_OP_REVALIDATE)
0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 41 rc = lower_dentry->d_op->d_revalidate(lower_dentry, name, flags);
5556e7e6d30e8e Tyler Hicks 2015-08-05 42
2b0143b5c986be David Howells 2015-03-17 43 if (d_really_is_positive(dentry)) {
5556e7e6d30e8e Tyler Hicks 2015-08-05 44 struct inode *inode = d_inode(dentry);
ae56fb16337c88 Michael Halcrow 2006-11-16 45
5556e7e6d30e8e Tyler Hicks 2015-08-05 46 fsstack_copy_attr_all(inode, ecryptfs_inode_to_lower(inode));
5556e7e6d30e8e Tyler Hicks 2015-08-05 47 if (!inode->i_nlink)
5556e7e6d30e8e Tyler Hicks 2015-08-05 48 return 0;
ae56fb16337c88 Michael Halcrow 2006-11-16 49 }
237fead619984c Michael Halcrow 2006-10-04 50 return rc;
237fead619984c Michael Halcrow 2006-10-04 51 }
237fead619984c Michael Halcrow 2006-10-04 52
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-08-17 9:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 0:41 [f2fs-dev] [PATCH v5 00/10] Support negative dentries on case-insensitive ext4 and f2fs Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 01/10] fs: Expose helper to check if a directory needs casefolding Gabriel Krisman Bertazi
2023-08-12 1:59 ` Eric Biggers
2023-08-12 23:06 ` Theodore Ts'o
2023-08-13 0:12 ` Eric Biggers
2023-08-13 3:08 ` Matthew Wilcox
2023-08-13 4:30 ` Eric Biggers
2023-08-14 11:38 ` Theodore Ts'o
2023-08-14 17:22 ` Eric Biggers
2023-08-15 3:59 ` Theodore Ts'o
2023-08-14 15:02 ` Gabriel Krisman Bertazi
2023-08-14 19:14 ` Eric Biggers
2023-08-14 19:26 ` Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 02/10] ecryptfs: Reject casefold directory inodes Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 03/10] 9p: Split ->weak_revalidate from ->revalidate Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 04/10] fs: Expose name under lookup to d_revalidate hooks Gabriel Krisman Bertazi
2023-08-12 2:15 ` Eric Biggers
2023-08-17 7:00 ` kernel test robot
2023-08-17 9:12 ` kernel test robot [this message]
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 05/10] fs: Add DCACHE_CASEFOLDED_NAME flag Gabriel Krisman Bertazi
2023-08-12 2:17 ` Eric Biggers
2023-08-14 15:03 ` Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 06/10] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi
2023-08-12 2:41 ` Eric Biggers
2023-08-14 14:50 ` Gabriel Krisman Bertazi
2023-08-14 18:42 ` Eric Biggers
2023-08-14 19:21 ` Gabriel Krisman Bertazi
2023-08-14 19:26 ` Eric Biggers
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 07/10] libfs: Chain encryption checks after case-insensitive revalidation Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 08/10] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 09/10] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi
2023-08-12 0:41 ` [f2fs-dev] [PATCH v5 10/10] f2fs: " Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308171740.0u9DuWtr-lkp@intel.com \
--to=lkp@intel.com \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).