From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891F3C433E0 for ; Tue, 4 Aug 2020 00:57:53 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 869CE206DA for ; Tue, 4 Aug 2020 00:57:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="djZYfM4a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="HUM8x3nd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 869CE206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k2lH6-0003XJ-9o; Tue, 04 Aug 2020 00:57:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2lH5-0003XB-6j for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2020 00:57:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=79/tnc5+DE/fSmIpQuMmXyyAVoNI9rLeSF+Ee728GOg=; b=djZYfM4a/Nhjs291sBGUqe8VhM zyNe2WpOw4Ew/Sx2DgBsEK0dU/kEO5x+HLLci+9DUPHhBK429R96HPfEhPNJBDVkxumXjAVvb2AbS 1UowW6qFBiu5wqY2N0B7DdzfTsD80gdNMBEXnpuSD9Q8gdb97evj2rAcu4lua2Pr99x8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=79/tnc5+DE/fSmIpQuMmXyyAVoNI9rLeSF+Ee728GOg=; b=HUM8x3ndDN+ohstfdHAh/FYRM7 yyI6FNzMxSxEFIxbBUNb0C1zv7s2PJ/gIs1RtdCSC+jsieFOYIgB9WM/jKRO4uIxAem2ifvclmYfd PzrBHmXWzDJsEdYjFFgUlMVHBuXCdE1vvNpsq66FRaBV7/4E4HSMVF9CS7uqgp8xoeYo=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k2lH4-008GfM-16 for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2020 00:57:51 +0000 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 82BDEFE8FF83CD2F15D5; Tue, 4 Aug 2020 08:57:34 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 4 Aug 2020 08:57:27 +0800 To: Zhihao Cheng , , , References: <20200801032450.3028986-1-chengzhihao1@huawei.com> From: Chao Yu Message-ID: <213c79b1-39cc-1b22-f2d9-d6b5ee3dbdab@huawei.com> Date: Tue, 4 Aug 2020 08:57:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200801032450.3028986-1-chengzhihao1@huawei.com> Content-Language: en-US X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected X-Headers-End: 1k2lH4-008GfM-16 Subject: Re: [f2fs-dev] [PATCH] f2fs: update_sit_entry: Make the judgment condition of f2fs_bug_on more intuitive X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/8/1 11:24, Zhihao Cheng wrote: > Current judgment condition of f2fs_bug_on in function update_sit_entry(): > new_vblocks >> (sizeof(unsigned short) << 3) || > new_vblocks > sbi->blocks_per_seg > > which equivalents to: > new_vblocks < 0 || new_vblocks > sbi->blocks_per_seg > > The latter is more intuitive. > > Signed-off-by: Zhihao Cheng > Reported-by: Jack Qiu Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel