From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [RFC PATCH v2] f2fs: support data compression
Date: Fri, 1 Nov 2019 18:05:44 +0800 [thread overview]
Message-ID: <33c09ea0-b521-77b7-dd84-a3ede003a793@huawei.com> (raw)
In-Reply-To: <20191031160105.GC60005@jaegeuk-macbookpro.roam.corp.google.com>
On 2019/11/1 0:01, Jaegeuk Kim wrote:
>> +f2fs-$(CONFIG_FS_COMPRESSION) += compress.o
> CONFIG_F2FS_FS_COMPRESSION?
Fixed.
>
>> +#ifdef F2FS_FS_COMPRESSION
> Do we need this?
Ditto.
>
>> +bool f2fs_is_compress_backend_ready(struct inode *inode)
>> +{
>> + if (!f2fs_compressed_file(inode))
>> + return true;
> #ifdef F2FS_FS_COMPRESSION
>> + return f2fs_cops[F2FS_I(inode)->i_compress_algorithm];
> #else
> return -EOPNOTSUPP;
> #endif
Ditto, I kept return value as boolean.
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-11-01 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 9:27 [f2fs-dev] [RFC PATCH v2] f2fs: support data compression Chao Yu
2019-10-31 16:01 ` Jaegeuk Kim
2019-11-01 10:05 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c09ea0-b521-77b7-dd84-a3ede003a793@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).