From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E0FC433E0 for ; Sun, 28 Jun 2020 02:56:42 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4FAE2080C for ; Sun, 28 Jun 2020 02:56:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="QIiptqgh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DRenA4n5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4FAE2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jpNUn-0007QM-DQ; Sun, 28 Jun 2020 02:56:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpNUl-0007QD-MU for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jun 2020 02:56:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RzypqlbnY5R1Lu95eoB7OksKDmxWThf6dMBLs9p+uO4=; b=QIiptqghwSg/GDZ4GeYW3tAjPo gZOQqSn1eAjUTFzxU/m+SXqDM4nPeWldVO5miLlqJ1HGuHafT+J7VuVXhtvYwwqbKJAEqFaCr2qJF O0jQYFoStdQVUQyERry47cNfcVGQRBu845PZOFNpSEorLVBsnivjGOqAmtIPvxRfOGjs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RzypqlbnY5R1Lu95eoB7OksKDmxWThf6dMBLs9p+uO4=; b=DRenA4n5bFGoUwaFXaV8tebFFb VtXNjqkGt22DygP7PRGgdrfSo2Ors5rNiNnlrVwSx2n+wJ3nimdjgjMrMFbiS6FScKk3olLNsc0Gq kCI7a2fww1KxQiniC9u9uuAoinOmMAb87j8XxBMN1yCIQPSflT/DxW9yn99AMdVqkJwI=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jpNUi-0038fJ-SN for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jun 2020 02:56:39 +0000 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 514568FD9B6562E8C76E; Sun, 28 Jun 2020 10:56:22 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sun, 28 Jun 2020 10:56:18 +0800 To: Liu Song , , References: <20200626143927.2792-1-fishland@aliyun.com> From: Chao Yu Message-ID: <34a73209-8384-2818-b6e1-c97fc9c32e69@huawei.com> Date: Sun, 28 Jun 2020 10:56:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200626143927.2792-1-fishland@aliyun.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jpNUi-0038fJ-SN Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary judgments in __insert_free_nid() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, liu.song11@zte.com.cn, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/6/26 22:39, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > The value of state must be equal to FREE_NID, so the if > condition judgment can be removed. > > Signed-off-by: Liu Song > --- > fs/f2fs/node.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 03e24df1c84f..0adeb20f19c9 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -2118,8 +2118,7 @@ static int __insert_free_nid(struct f2fs_sb_info *sbi, > > f2fs_bug_on(sbi, state != i->state); > nm_i->nid_cnt[state]++; > - if (state == FREE_NID) > - list_add_tail(&i->list, &nm_i->free_nid_list); > + list_add_tail(&i->list, &nm_i->free_nid_list); In previous design, @state allow accepting both FREE_NID and PREALLOC_NID, If you remove that condition, it's not correct to add free nid entry into free_nid_list when passing PREALLOC_NID in @state, now, we only pass @state with FREE_NID, so it's better to remove that parameter directly. Thanks, > return 0; > } > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel