From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A645C43331 for ; Fri, 6 Sep 2019 11:00:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFE37206A1 for ; Fri, 6 Sep 2019 11:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Gj00Rhdb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="kqWJ7iXk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFE37206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Bz6-0001o6-WD; Fri, 06 Sep 2019 11:00:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i6Bz5-0001nz-Qj for linux-f2fs-devel@lists.sourceforge.net; Fri, 06 Sep 2019 11:00:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AENyjDoNKuTFDZvEaZswmGLH3A6rvrVQ8XWyT2sQ2TM=; b=Gj00RhdbMpSmPRdKy9PpVZ5oJw QHFhb7bR2oR65ql3eLaOGiDrhgC07Yg++H0GPIeIKxsJu2ZekNgHAiKEmrhQ82l/KR263Eyd8LPPn J+BwedPLQVaIWeBekgZLRdpWxEjPBRCPdk9PrGgRahXiobJVI8SJZy0seEbD1TR7gJvs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AENyjDoNKuTFDZvEaZswmGLH3A6rvrVQ8XWyT2sQ2TM=; b=kqWJ7iXkW5fe3+nttN38OfysoI cu4AJ0TIeT05S3zuR6SsyfcGYhMPqO8IeK1YfKWj0J+8MA/oTEW/5xWM1msLgon1F/4rjwgIE6aN7 OvMqMILmvC9PWjo8J9crxRxw20ta4VBRLgvfDc1disMiJKLxb338HODyDnOQr9Hh7vr0=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1i6Bz4-001ovP-36 for linux-f2fs-devel@lists.sourceforge.net; Fri, 06 Sep 2019 11:00:55 +0000 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 3A31F2511DB9331D1880; Fri, 6 Sep 2019 19:00:46 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Sep 2019 19:00:42 +0800 To: Sahitya Tummala , References: <1565185232-11506-1-git-send-email-stummala@codeaurora.org> <2b8f7a88-5204-a4ea-9f80-1056abb30d98@kernel.org> From: Chao Yu Message-ID: <355d24c1-b07c-f8ff-1ab9-3f85653ced60@huawei.com> Date: Fri, 6 Sep 2019 19:00:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2b8f7a88-5204-a4ea-9f80-1056abb30d98@kernel.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1i6Bz4-001ovP-36 Subject: Re: [f2fs-dev] [PATCH v4] f2fs: Fix indefinite loop in f2fs_gc() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Sahitya, Luckily, I can reproduce this issue with generic/269, and have sent another patch for the issue, could you please check that one? Thanks, On 2019/8/7 22:06, Chao Yu wrote: > On 2019-8-7 21:40, Sahitya Tummala wrote: >> Policy - Foreground GC, LFS and greedy GC mode. >> >> Under this policy, f2fs_gc() loops forever to GC as it doesn't have >> enough free segements to proceed and thus it keeps calling gc_more >> for the same victim segment. This can happen if the selected victim >> segment could not be GC'd due to failed blkaddr validity check i.e. >> is_alive() returns false for the blocks set in current validity map. >> >> Fix this by keeping track of such invalid segments and skip those >> segments for selection in get_victim_by_default() to avoid endless >> GC loop under such error scenarios. Currently, add this logic under >> CONFIG_F2FS_CHECK_FS to be able to root cause the issue in debug >> version. >> >> Signed-off-by: Sahitya Tummala >> --- >> v4: Cover all logic with CONFIG_F2FS_CHECK_FS >> >> fs/f2fs/gc.c | 31 +++++++++++++++++++++++++++++-- >> fs/f2fs/segment.c | 14 +++++++++++++- >> fs/f2fs/segment.h | 3 +++ >> 3 files changed, 45 insertions(+), 3 deletions(-) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index 8974672..cbcacbd 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -382,6 +382,16 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, >> nsearched++; >> } >> >> +#ifdef CONFIG_F2FS_CHECK_FS >> + /* >> + * skip selecting the invalid segno (that is failed due to block >> + * validity check failure during GC) to avoid endless GC loop in >> + * such cases. >> + */ >> + if (test_bit(segno, sm->invalid_segmap)) >> + goto next; >> +#endif >> + >> secno = GET_SEC_FROM_SEG(sbi, segno); >> >> if (sec_usage_check(sbi, secno)) >> @@ -602,8 +612,15 @@ static bool is_alive(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, >> { >> struct page *node_page; >> nid_t nid; >> - unsigned int ofs_in_node; >> + unsigned int ofs_in_node, segno; >> block_t source_blkaddr; >> + unsigned long offset; >> +#ifdef CONFIG_F2FS_CHECK_FS >> + struct sit_info *sit_i = SIT_I(sbi); >> +#endif >> + >> + segno = GET_SEGNO(sbi, blkaddr); >> + offset = GET_BLKOFF_FROM_SEG0(sbi, blkaddr); >> >> nid = le32_to_cpu(sum->nid); >> ofs_in_node = le16_to_cpu(sum->ofs_in_node); >> @@ -627,8 +644,18 @@ static bool is_alive(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, >> source_blkaddr = datablock_addr(NULL, node_page, ofs_in_node); >> f2fs_put_page(node_page, 1); >> >> - if (source_blkaddr != blkaddr) >> + if (source_blkaddr != blkaddr) { >> +#ifdef CONFIG_F2FS_CHECK_FS > > unsigned int segno = GET_SEGNO(sbi, blkaddr); > unsigned int offset = GET_BLKOFF_FROM_SEG0(sbi, blkaddr); > > Should be local, otherwise it looks good to me, I think Jaegeuk can help to fix > this while merging. > > Reviewed-by: Chao Yu > > Thanks, > >> + if (unlikely(check_valid_map(sbi, segno, offset))) { >> + if (!test_and_set_bit(segno, sit_i->invalid_segmap)) { >> + f2fs_err(sbi, "mismatched blkaddr %u (source_blkaddr %u) in seg %u\n", >> + blkaddr, source_blkaddr, segno); >> + f2fs_bug_on(sbi, 1); >> + } >> + } >> +#endif >> return false; >> + } >> return true; >> } >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index a661ac3..ee795b1 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -806,6 +806,9 @@ static void __remove_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno, >> enum dirty_type dirty_type) >> { >> struct dirty_seglist_info *dirty_i = DIRTY_I(sbi); >> +#ifdef CONFIG_F2FS_CHECK_FS >> + struct sit_info *sit_i = SIT_I(sbi); >> +#endif >> >> if (test_and_clear_bit(segno, dirty_i->dirty_segmap[dirty_type])) >> dirty_i->nr_dirty[dirty_type]--; >> @@ -817,9 +820,13 @@ static void __remove_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno, >> if (test_and_clear_bit(segno, dirty_i->dirty_segmap[t])) >> dirty_i->nr_dirty[t]--; >> >> - if (get_valid_blocks(sbi, segno, true) == 0) >> + if (get_valid_blocks(sbi, segno, true) == 0) { >> clear_bit(GET_SEC_FROM_SEG(sbi, segno), >> dirty_i->victim_secmap); >> +#ifdef CONFIG_F2FS_CHECK_FS >> + clear_bit(segno, sit_i->invalid_segmap); >> +#endif >> + } >> } >> } >> >> @@ -4015,6 +4022,10 @@ static int build_sit_info(struct f2fs_sb_info *sbi) >> sit_i->sit_bitmap_mir = kmemdup(src_bitmap, bitmap_size, GFP_KERNEL); >> if (!sit_i->sit_bitmap_mir) >> return -ENOMEM; >> + >> + sit_i->invalid_segmap = f2fs_kvzalloc(sbi, bitmap_size, GFP_KERNEL); >> + if (!sit_i->invalid_segmap) >> + return -ENOMEM; >> #endif >> >> /* init SIT information */ >> @@ -4517,6 +4528,7 @@ static void destroy_sit_info(struct f2fs_sb_info *sbi) >> kvfree(sit_i->sit_bitmap); >> #ifdef CONFIG_F2FS_CHECK_FS >> kvfree(sit_i->sit_bitmap_mir); >> + kvfree(sit_i->invalid_segmap); >> #endif >> kvfree(sit_i); >> } >> diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h >> index b746028..9370d53 100644 >> --- a/fs/f2fs/segment.h >> +++ b/fs/f2fs/segment.h >> @@ -229,6 +229,9 @@ struct sit_info { >> char *sit_bitmap; /* SIT bitmap pointer */ >> #ifdef CONFIG_F2FS_CHECK_FS >> char *sit_bitmap_mir; /* SIT bitmap mirror */ >> + >> + /* bitmap of segments to be ignored by GC in case of errors */ >> + unsigned long *invalid_segmap; >> #endif >> unsigned int bitmap_size; /* SIT bitmap size */ >> >> > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel