* [f2fs-dev] [PATCH] f2fs: correct statistic of APP_DIRECT_IO
@ 2020-08-29 10:05 Jack Qiu
2020-08-30 3:38 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Jack Qiu @ 2020-08-29 10:05 UTC (permalink / raw)
To: linux-f2fs-devel
Miss to update APP_DIRECT_IO when receiving async DIO. For example:
fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1
-name=fill -size=10m -numjobs=1 -iodepth=32 -rw=write
Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
---
fs/f2fs/data.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a19e2a7891f3..f9f25bc52487 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3671,12 +3671,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
err);
if (!do_opu)
set_inode_flag(inode, FI_UPDATE_WRITE);
+ } else if (err == -EIOCBQUEUED) {
+ f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
+ count - iov_iter_count(iter));
} else if (err < 0) {
f2fs_write_failed(mapping, offset + count);
}
} else {
if (err > 0)
f2fs_update_iostat(sbi, APP_DIRECT_READ_IO, err);
+ else if (err == -EIOCBQUEUED)
+ f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
+ count - iov_iter_count(iter));
}
out:
--
2.17.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: correct statistic of APP_DIRECT_IO
2020-08-29 10:05 [f2fs-dev] [PATCH] f2fs: correct statistic of APP_DIRECT_IO Jack Qiu
@ 2020-08-30 3:38 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-08-30 3:38 UTC (permalink / raw)
To: Jack Qiu, linux-f2fs-devel
On 2020-8-29 18:05, Jack Qiu wrote:
> Miss to update APP_DIRECT_IO when receiving async DIO. For example:
> fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1
> -name=fill -size=10m -numjobs=1 -iodepth=32 -rw=write
>
> Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
> ---
> fs/f2fs/data.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index a19e2a7891f3..f9f25bc52487 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3671,12 +3671,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
> err);
> if (!do_opu)
> set_inode_flag(inode, FI_UPDATE_WRITE);
> + } else if (err == -EIOCBQUEUED) {
> + f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
> + count - iov_iter_count(iter));
> } else if (err < 0) {
> f2fs_write_failed(mapping, offset + count);
> }
> } else {
> if (err > 0)
> f2fs_update_iostat(sbi, APP_DIRECT_READ_IO, err);
> + else if (err == -EIOCBQUEUED)
> + f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
APP_DIRECT_READ_IO
Thanks,
> + count - iov_iter_count(iter));
> }
>
> out:
> --
> 2.17.1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-30 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 10:05 [f2fs-dev] [PATCH] f2fs: correct statistic of APP_DIRECT_IO Jack Qiu
2020-08-30 3:38 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).