From: Miko Larsson <mikoxyzzz@gmail.com>
To: yonggil.song@samsung.com, Chao Yu <chao@kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Seokhwan Kim <sukka.kim@samsung.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem
Date: Thu, 16 Feb 2023 08:01:36 +0100 [thread overview]
Message-ID: <49fe0a38e1340987be9c898fa806ce5776cba639.camel@gmail.com> (raw)
In-Reply-To: <20230216025743epcms2p31d1bde5cfb315d13231010b0a46fbec4@epcms2p3>
On Thu, 2023-02-16 at 11:57 +0900, Yonggil Song wrote:
> When f2fs skipped a gc round during victim migration, there was a bug
> which
> would skip all upcoming gc rounds unconditionally because
> skipped_gc_rwsem
> was not initialized. It fixes the bug by correctly initializing the
> skipped_gc_rwsem inside the gc loop.
>
> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
> Signed-off-by: Yonggil Song <yonggil.song@samsung.com>
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index b22f49a6f128..81d326abaac1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1786,8 +1786,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct
> f2fs_gc_control *gc_control)
> prefree_segments(sbi));
>
> cpc.reason = __get_cp_reason(sbi);
> - sbi->skipped_gc_rwsem = 0;
> gc_more:
> + sbi->skipped_gc_rwsem = 0;
> if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) {
> ret = -EINVAL;
> goto stop;
Might want to Cc the stable mailing list.
--
~miko
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-02-16 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230215024850epcms2p22be2cc864d82b44f31c19a7ef28770b6@epcms2p3>
2023-02-16 2:57 ` [f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem Yonggil Song
2023-02-16 7:01 ` Miko Larsson [this message]
2023-02-16 7:28 ` Yonggil Song
[not found] <CGME20230215024850epcms2p22be2cc864d82b44f31c19a7ef28770b6@epcms2p4>
2023-02-16 7:44 ` Yonggil Song
2023-02-16 7:46 ` gregkh
2023-03-13 20:20 ` patchwork-bot+f2fs
[not found] <CGME20230215024850epcms2p22be2cc864d82b44f31c19a7ef28770b6@epcms2p7>
2023-02-16 7:13 ` Yonggil Song
2023-03-06 21:51 ` Jaegeuk Kim
2023-03-13 6:11 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49fe0a38e1340987be9c898fa806ce5776cba639.camel@gmail.com \
--to=mikoxyzzz@gmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sukka.kim@samsung.com \
--cc=yonggil.song@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).