From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65068C41621 for ; Tue, 24 Mar 2020 09:09:15 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31CDB205ED; Tue, 24 Mar 2020 09:09:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="SwHP6trr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Tje8wk4F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31CDB205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jGfYg-0000S0-Pd; Tue, 24 Mar 2020 09:09:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jGfYd-0000RE-Od for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Mar 2020 09:09:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q5cJrdiSP4+QQrJqfVPNmUDzA7i4ynYSE1vRDsFve3E=; b=SwHP6trrh4Exl9MGgqd2cCODyt /3FGHw/PwVZts+tyj8HmKANdVZJXE6gyRsCpzKcFpuvMTjPsnXfN4DDrU95nY1R2/jWfydqyx/6fo 35IhLvswGnSW0WuhpcZrQl83abJo20nLfrVvhFfvuI9hoVNyLuUd7uQ/FxpJ8CpqiYcc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q5cJrdiSP4+QQrJqfVPNmUDzA7i4ynYSE1vRDsFve3E=; b=Tje8wk4FPeZlWZrr7G74fZtETS sX9Cu+NoWXr+LV5iZVCopW4981omueIm+miGDVMuh2r3FVT8vYFVTNwpfTPB/xmujVNx1O6jRn9SM JeaPNGZ0d7vto/Pn77YvthLZ4NjhCOWNrUAhxoVu4rsL/2P64zwH6Uydx+16eopWzZfY=; Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jGfYb-001mxn-G3 for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Mar 2020 09:09:11 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 91A9F400B6F2CCFD201C; Tue, 24 Mar 2020 17:09:00 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 24 Mar 2020 17:08:58 +0800 To: Sahitya Tummala , Jaegeuk Kim , References: <1584506689-5041-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: <54ae330b-ac9b-7968-fa0a-95db6737e3ea@huawei.com> Date: Tue, 24 Mar 2020 17:08:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1584506689-5041-1-git-send-email-stummala@codeaurora.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jGfYb-001mxn-G3 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix long latency due to discard during umount X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/3/18 12:44, Sahitya Tummala wrote: > F2FS already has a default timeout of 5 secs for discards that > can be issued during umount, but it can take more than the 5 sec > timeout if the underlying UFS device queue is already full and there > are no more available free tags to be used. In that case, submit_bio() > will wait for the already queued discard requests to complete to get > a free tag, which can potentially take way more than 5 sec. > > Fix this by submitting the discard requests with REQ_NOWAIT > flags during umount. This will return -EAGAIN for UFS queue/tag full > scenario without waiting in the context of submit_bio(). The FS can > then handle these requests by retrying again within the stipulated > discard timeout period to avoid long latencies. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel