From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA324C433E0 for ; Thu, 18 Jun 2020 07:08:09 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DC3821532; Thu, 18 Jun 2020 07:08:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="IQVPT9qh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="OK1336RN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DC3821532 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jloee-0002FS-U4; Thu, 18 Jun 2020 07:08:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jloed-0002FK-BI for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 07:08:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H5vf+Cfp7KQy+RFdB+RXpnhiFeJn767pyq5LG7St9+U=; b=IQVPT9qh1k+npJS4bcBg+ox9Pc nuIXSlVLRY0H1VVI0c/rR6QMdJt/mFPL6kXmSGhGx3Muw9oHjl9hxpmMEbnAhoLodCt8eR9vkuGbU 47uFxMp/L6ydQVEyc1hWGFgzRm3kUTmFuJnFCQB16Ru28jNlfEZszgsrLuPDMAgOqAks=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=H5vf+Cfp7KQy+RFdB+RXpnhiFeJn767pyq5LG7St9+U=; b=OK1336RN8wjkgxuV8fLhZh1YSu TsK3Q1yvFVCmGEEuOy4YgDmwNxmNHyVQ0Yd6EQN801H++AW2kpH87x6O8G2LVyutTcQT5iT0fW/FT hF/Eavl3we4LPXhIcOak2z2UyresHpbUluXYtw82HBp9fHOptDLkzU5WRrcKw0Qcl2oU=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jloeb-007zkS-7Z for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 07:08:07 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0C771A4BE1794B993500 for ; Thu, 18 Jun 2020 15:07:56 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 18 Jun 2020 15:07:46 +0800 To: Jack Qiu , References: <20200618043710.35938-1-jack.qiu@huawei.com> From: Chao Yu Message-ID: <54c3c554-25c1-d848-193d-cfc5a2c5d63a@huawei.com> Date: Thu, 18 Jun 2020 15:07:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200618043710.35938-1-jack.qiu@huawei.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jloeb-007zkS-7Z Subject: Re: [f2fs-dev] [PATCH v2] f2fs: get the right gc victim section when section has several segments X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/6/18 12:37, Jack Qiu wrote: > Assume each section has 4 segment: > .___________________________. > |_Segment0_|_..._|_Segment3_| > . . > . . > .__________. > |_section0_| > > Segment 0~2 has 0 valid block, segment 3 has 512 valid blocks. > It will fail if we want to gc section0 in this scenes, > because all 4 segments in section0 is not dirty. > So we should use dirty section bitmap instead of dirty segment bitmap > to get right victim section. > > Signed-off-by: Jack Qiu Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel