From: Chao Yu <chao@kernel.org>
To: Lihong Kou <koulihong@huawei.com>,
yuchao0@huawei.com, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, fangwei1@huawei.com
Subject: Re: [f2fs-dev] [PATCH] f2fs: cleanup the code in build_sit_entries.
Date: Mon, 5 Aug 2019 21:13:19 +0800 [thread overview]
Message-ID: <632c947b-2c44-b48d-e80e-0f6c43ac2f6d@kernel.org> (raw)
In-Reply-To: <1565003632-124792-1-git-send-email-koulihong@huawei.com>
On 2019-8-5 19:13, Lihong Kou wrote:
> We do not need to set the SBI_NEED_FSCK flag in the error paths, if we
> return error here, we will not update the checkpoint flag, so the code
> is useless, just remove it.
>
> Signed-off-by: Lihong Kou <koulihong@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-08-05 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 11:13 [f2fs-dev] [PATCH] f2fs: cleanup the code in build_sit_entries Lihong Kou
2019-08-05 13:13 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=632c947b-2c44-b48d-e80e-0f6c43ac2f6d@kernel.org \
--to=chao@kernel.org \
--cc=fangwei1@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=koulihong@huawei.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).