From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2156C2D0C8 for ; Thu, 26 Dec 2019 03:45:05 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 940F7206A4 for ; Thu, 26 Dec 2019 03:45:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="CdKsgULa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="aayG7gBl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 940F7206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ikK5A-0007x3-J9; Thu, 26 Dec 2019 03:45:04 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ikK59-0007ws-GZ for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Dec 2019 03:45:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jaa1f12tqpemdSV2/Gz1Akb+/Lggk0e3GbuNq1fC1Ms=; b=CdKsgULaIsnaQt8BE+qTL3XbuZ mGpiquI8vu90F6hc//VSXOjsRumopIO+yF5e1bQOgQ/Wh5ZzX0H/G57ypNnMk2/047YOmWU2+YFWw bctoJPLDAtmVLCzwimQ3bV5LNYIPkiHglrZjfPtYHsFrkOQZhJ9jYreuRIjOVrZdHYKw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jaa1f12tqpemdSV2/Gz1Akb+/Lggk0e3GbuNq1fC1Ms=; b=aayG7gBlgJeqfv6x5BQ6nfG1Ck 7RLEb2XO7vv1rpgjBqk+K6Li3AKXX0S0mdTCBvpvzGqSTN+/5mXOxTTsdNRvVFo7eDsg2qjdXY/tR PG9d55PzCLj8CtVxK3P6eH5aLDHWXLVQRvAgEe6RZ/7Zs2yNVYG0TnztlQ0d40/L4Eyo=; Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1ikK57-00E0lN-Es for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Dec 2019 03:45:03 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 861DFF9DD7EAD9D01967; Thu, 26 Dec 2019 11:44:52 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Dec 2019 11:44:44 +0800 To: YueHaibing , , References: <20191224124359.15040-1-yuehaibing@huawei.com> From: Chao Yu Message-ID: <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com> Date: Thu, 26 Dec 2019 11:44:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191224124359.15040-1-yuehaibing@huawei.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1ikK57-00E0lN-Es Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'cs_block' X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/12/24 20:43, YueHaibing wrote: > fs/f2fs/segment.c: In function fix_curseg_write_pointer: > fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable] > > It is never used since commit 362d8a920384 ("f2fs: Check > write pointer consistency of open zones") , so remove it. Thanks for the fix! Do you mind merging this patch to original patch? as it's still pending in dev branch. Thanks, > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > fs/f2fs/segment.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index a951953..72cf257 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -4482,14 +4482,13 @@ static int fix_curseg_write_pointer(struct f2fs_sb_info *sbi, int type) > struct f2fs_dev_info *zbd; > struct blk_zone zone; > unsigned int cs_section, wp_segno, wp_blkoff, wp_sector_off; > - block_t cs_zone_block, wp_block, cs_block; > + block_t cs_zone_block, wp_block; > unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT; > sector_t zone_sector; > int err; > > cs_section = GET_SEC_FROM_SEG(sbi, cs->segno); > cs_zone_block = START_BLOCK(sbi, GET_SEG_FROM_SEC(sbi, cs_section)); > - cs_block = START_BLOCK(sbi, cs->segno) + cs->next_blkoff; > > zbd = get_target_zoned_dev(sbi, cs_zone_block); > if (!zbd) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel