From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH RFC 2/5] f2fs: record average update time of segment
Date: Fri, 3 Jul 2020 10:13:17 +0800 [thread overview]
Message-ID: <70776961-0430-0a9f-cf26-09a2cc192b07@huawei.com> (raw)
In-Reply-To: <20200701161927.GD1724572@google.com>
On 2020/7/2 0:19, Jaegeuk Kim wrote:
> On 06/30, Chao Yu wrote:
>> Previously, once we update one block in segment, we will update mtime of
>> segment to last time, making aged segment becoming freshest, result in
>> that GC with cost benefit algorithm missing such segment, So this patch
>> changes to record mtime as average block updating time instead of last
>> updating time.
>>
>> It's not needed to reset mtime for prefree segment, as se->valid_blocks
>> is zero, then old se->mtime won't take any weight with below calculation:
>>
>> se->mtime = (se->mtime * se->valid_blocks + mtime) /
>> (se->valid_blocks + 1);
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/segment.c | 21 ++++++++++++++++++---
>> 1 file changed, 18 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 863ec6f1fb87..906c313835ad 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -2150,6 +2150,22 @@ static void __set_sit_entry_type(struct f2fs_sb_info *sbi, int type,
>> __mark_sit_entry_dirty(sbi, segno);
>> }
>>
>> +static void update_segment_mtime(struct f2fs_sb_info *sbi, block_t blkaddr)
>> +{
>> + unsigned int segno = GET_SEGNO(sbi, blkaddr);
>> + struct seg_entry *se = get_seg_entry(sbi, segno);
>> + unsigned long long mtime = get_mtime(sbi, false);
>> +
>> + if (!se->mtime) {
>
> Don't need {}.
Updated,
BTW, have fixed below compile error:
m68k-linux-ld: fs/f2fs/segment.o: in function `update_segment_mtime':
fs/f2fs/segment.c:2162: undefined reference to `__udivdi3'
Thanks,
>
>> + se->mtime = mtime;
>> + } else {
>> + se->mtime = (se->mtime * se->valid_blocks + mtime) /
>> + (se->valid_blocks + 1);
>> + }
>> + if (mtime > SIT_I(sbi)->max_mtime)
>> + SIT_I(sbi)->max_mtime = mtime;
>> +}
>> +
>> static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
>> {
>> struct seg_entry *se;
>> @@ -2169,10 +2185,9 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
>> f2fs_bug_on(sbi, (new_vblocks >> (sizeof(unsigned short) << 3) ||
>> (new_vblocks > sbi->blocks_per_seg)));
>>
>> + update_segment_mtime(sbi, blkaddr);
>> +
>> se->valid_blocks = new_vblocks;
>> - se->mtime = get_mtime(sbi, false);
>> - if (se->mtime > SIT_I(sbi)->max_mtime)
>> - SIT_I(sbi)->max_mtime = se->mtime;
>>
>> /* Update valid block bitmap */
>> if (del > 0) {
>> --
>> 2.26.2
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-03 2:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 10:04 [f2fs-dev] [PATCH RFC 1/5] f2fs: introduce inmem curseg Chao Yu
2020-06-30 10:04 ` [f2fs-dev] [PATCH RFC 2/5] f2fs: record average update time of segment Chao Yu
2020-07-01 16:19 ` Jaegeuk Kim
2020-07-03 2:13 ` Chao Yu [this message]
2020-06-30 10:04 ` [f2fs-dev] [PATCH RFC 3/5] f2fs: inherit mtime of original block during GC Chao Yu
2020-06-30 10:04 ` [f2fs-dev] [PATCH RFC 4/5] f2fs: support 64-bits key in f2fs rb-tree node entry Chao Yu
2020-06-30 10:04 ` [f2fs-dev] [PATCH RFC 5/5] f2fs: support age threshold based garbage collection Chao Yu
2020-07-06 8:25 ` Chao Yu
2020-07-07 3:21 ` [f2fs-dev] [PATCH RFC 1/5] f2fs: introduce inmem curseg Jaegeuk Kim
2020-07-07 3:37 ` Chao Yu
2020-07-07 3:51 ` Jaegeuk Kim
2020-07-15 3:39 ` Chao Yu
2020-07-15 19:07 ` Jaegeuk Kim
2020-07-16 1:24 ` Chao Yu
2020-07-25 8:42 ` Chao Yu
2020-08-04 1:49 ` Chao Yu
2020-08-04 2:44 ` Jaegeuk Kim
2020-08-04 2:53 ` Chao Yu
2020-08-04 3:56 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70776961-0430-0a9f-cf26-09a2cc192b07@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).