From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89168C41514 for ; Tue, 27 Aug 2019 14:54:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56FA0217F5; Tue, 27 Aug 2019 14:54:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="T0u4x+ek"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="a2468NQl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ZYGFDPVn"; dkim=neutral (0-bit key) header.d=android.com header.i=@android.com header.b="mzwUwotH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56FA0217F5 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID: References:To:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ST8d0bUMCFDnWo+r5m5G4f3vD7W6aCZ1E5nPAL5btU=; b=T0u4x+ek3kXgXXhueq+rdht9PR U4RTxYK5L8zPzsgNW9rZgRykglWZOrbCM2+A1uwWHim67P7AV8K1qDwrGFrdrQsSRJQWVOJ5g7jJk Lt4zVfMz4QzkY6VJJGRByejUTD9muM4i8hVVGOV7f56y/mccrGCixBU/ATs2WaM6kBMg=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i2cs5-0002wB-QJ; Tue, 27 Aug 2019 14:54:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i2cs4-0002vp-C5 for linux-f2fs-devel@lists.sourceforge.net; Tue, 27 Aug 2019 14:54:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=a2468NQlOxUuo7f/3akZeQMtpp pQ6zahzEh/pcD9fS3XwPHJLqKAkye5w1PG6YzMLC8cCtymopcEh58kqHtMuZiiysXV+HVl2LidNGa sXBDoxeUphbWCnSj/fDOkykfG4pp/78VXD/UWvAFTYor9vxspBKr4KeqMVQYNgwEpS8Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=ZYGFDPVnZf9SuuMExWcTt14geH wGQWruRouGlaGE7uovaBdW3Aj0dVRpl0nJRrQAmzQ4QC/Mgye4xpyLdD/VyXxUoft0Oc2MolT0fH5 aJf9N1AQH+ah5rVX/wol5wWk83pzGimMJHD8Dw5LikGihOjkY8Abyh2LwJ6ZFbnFZTHM=; Received: from mail-pf1-f195.google.com ([209.85.210.195]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1i2cs2-004xUI-3t for linux-f2fs-devel@lists.sourceforge.net; Tue, 27 Aug 2019 14:54:56 +0000 Received: by mail-pf1-f195.google.com with SMTP id 196so14275463pfz.8 for ; Tue, 27 Aug 2019 07:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=mzwUwotHCHLyC8kvJQKX2qfkclXUibOZVKlCSAmub430gCcW4lmMANVBjk4ZJn37Mz lmwqaekfvRnk91fWBTPe9MdR6DNIOZYbn1kKQlCtB2EIRUw9eVK89gLHZxbOnS+BoN9O z/e+lec1c3V+A/cevmzn6YhUNeV1qLcxR5P5ZMIEm0QeC99vQIqrptkzAecOAow3P+WG qTbXtfhvLGsZsqUEkNrN67J91EYh7XB3OB1b7OQP26/5Ffe7WcOAgQyPgjx4Kr7W8Oc+ UwQjFeNzqy6bSLsp44PwvDCnhYQ/gCS2wppnuYUD4QcGMN8OxcAFpKCWSwZ+EWDarzDN vqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=TL3nN65jUKDQhnmNF0ZqCTFF/x60K+k11k29WEjT1+uMcLY42elQ7wAnW5t95IsnU3 ckPBYFrE5a4dFPm0/MT7qJVCreeJc+vFGnzZiM+ELp7z7VbMnoBif0b58uFwRIgr+euP U3j6flbjjd+8DyC/X372+y3Vnb13B4CBD4ibenxT/jSqwXH/EIIF07Nmia4tPpfR2n4n L5M7MTenVIwab6Ewv4a4rJ2GMbQUCPx4jBSzbua/UrcgPsQCS+X9WoXO2OZS0iGRcWA0 kvwQVq+N5KAO134fesAiMZjkUi+Hd8ZV2Ez/stD+MDd3aWPp6INuyy3gt5QgCvhySoRE 33uA== X-Gm-Message-State: APjAAAXGS2Zfn9Y2rF7B+rGW45pAiNinPUd0+D17MXxMW4gZScjqQGea Zw37aUcZEe3kQ4Ymak90AIs3gQ== X-Google-Smtp-Source: APXvYqwBoH7/mHEw1qHJ4C0pvUdOnWf9w3cFM7T1JRRoXNt8gEzBDpTDPLau8WREch+lyRDJT+u4BA== X-Received: by 2002:a65:6891:: with SMTP id e17mr20940506pgt.305.1566917687986; Tue, 27 Aug 2019 07:54:47 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id s125sm30946505pfc.133.2019.08.27.07.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2019 07:54:47 -0700 (PDT) To: Jan Kara References: <20190820180716.129882-1-salyzyn@android.com> <20190827141952.GB10098@quack2.suse.cz> Message-ID: <8468b22d-05b7-47d3-eb93-2c71dafea3ee@android.com> Date: Tue, 27 Aug 2019 07:54:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190827141952.GB10098@quack2.suse.cz> Content-Language: en-GB X-Headers-End: 1i2cs2-004xUI-3t Subject: Re: [f2fs-dev] [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mark Salyzyn via Linux-f2fs-devel Reply-To: Mark Salyzyn Cc: Latchesar Ionkov , Eric Sandeen , Mike Marshall , linux-xfs@vger.kernel.org, James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , "David S. Miller" , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Hugh Dickins , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Joseph Qi , samba-technical@lists.samba.org, Steve French , Bob Peterson , Tejun Heo , linux-erofs@lists.ozlabs.org, Anna Schumaker , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Eric Biggers , Dominique Martinet , Jeff Mahoney , linux-unionfs@vger.kernel.org, David Howells , linux-mm@kvack.org, Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , linux-security-module@vger.kernel.org, cluster-devel@redhat.com, v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, Adrian Hunter , stable@vger.kernel.org, Tyler Hicks , =?UTF-8?Q?Ernesto_A=2e_Fern=c3=a1ndez?= , Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 8/27/19 7:19 AM, Jan Kara wrote: > On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: >> diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking >> index 204dd3ea36bb..e2687f21c7d6 100644 >> --- a/Documentation/filesystems/Locking >> +++ b/Documentation/filesystems/Locking >> @@ -101,12 +101,10 @@ of the locking scheme for directory operations. >> ----------------------- xattr_handler operations ----------------------- >> prototypes: >> bool (*list)(struct dentry *dentry); >> - int (*get)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, void *buffer, >> - size_t size); >> - int (*set)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, const void *buffer, >> - size_t size, int flags); >> + int (*get)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); >> + int (*set)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); > The prototype here is really "struct xattr_gs_flags *args", isn't it? > Otherwise feel free to add: > > Reviewed-by: Jan Kara > > for the ext2, ext4, ocfs2, reiserfs, and the generic fs/* bits. > > Honza Thanks and good catch, will respin with a fix to the documentation shortly. -- Mark _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel