From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747ACC433DF for ; Thu, 18 Jun 2020 02:58:01 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42C7420776; Thu, 18 Jun 2020 02:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="O83sm5lq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="kMyBRfUo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42C7420776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jlkka-0007Bl-RX; Thu, 18 Jun 2020 02:58:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlkkZ-0007Be-98 for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 02:57:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mYYMIvs8QhDVLflZs5iSo7ZB/Z1kIlEHfEKFLYvx5jg=; b=O83sm5lq/fA6lWk0q9KVlco7No +MpPASFFPIiYBxBAMmnZF9vRt7lE30lSk3Rk6LZ7vHptIcLmDrXl3h0B0Jeo+Ink39XpIkIHULcQm UQy8/fIzUvpHQ9tI+X6afGRKtyWAmAKaEgaAt0sLa5AJJysQW+63OWSBpq/md7cPB820=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mYYMIvs8QhDVLflZs5iSo7ZB/Z1kIlEHfEKFLYvx5jg=; b=kMyBRfUo4Jwxp3ttkDFBS8njSb dSBgaKJfeHSNIMxZaWYoWq7EUbtNdAXs19BkhEX4WYy7R7/FukVnjUKALK7fGO8QZV6dZb7TkUNxm ZHPx5Lvp2EKPAJEqDc1Ihf3vzgrslRh+o7bGNVdf6UZvpzog13vuVHh1iDFpf9+WBA7o=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jlkkW-0075bG-Og for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 02:57:59 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 016FE8AB76B30C6AFD00; Thu, 18 Jun 2020 10:57:50 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 18 Jun 2020 10:57:49 +0800 To: Zac , References: <1592384659-20203-1-git-send-email-zhaowuyun@wingtech.com> <86069ba3-cba3-7bc9-c90b-e931abd0dde5@huawei.com> <000001d64519$b05a1180$110e3480$@wingtech.com> From: Chao Yu Message-ID: <86c34c66-b370-6c6d-91fe-b9235f9c5785@huawei.com> Date: Thu, 18 Jun 2020 10:57:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <000001d64519$b05a1180$110e3480$@wingtech.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jlkkW-0075bG-Og Subject: Re: [f2fs-dev] =?utf-8?b?5Zue5aSNOiBbUEFUQ0hdIGYyZnM6IGZpeCBhIHJh?= =?utf-8?q?ce_condition_between_f2fs=5Fwrite=5Fend=5Fio_and_f2fs=5Fdel=5Ff?= =?utf-8?q?sync=5Fnode=5Fentry?= X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/6/18 10:39, Zac wrote: > >> On 2020/6/17 17:04, zhaowuyun@wingtech.com wrote: >>> From: Wuyun Zhao >>> >>> Under some condition, the __write_node_page will submit a page which is >> not >>> f2fs_in_warm_node_list and will not call f2fs_add_fsync_node_entry. >>> f2fs_gc continue to run to invoke f2fs_iget -> do_read_inode to read the >> same node page >>> and set code node, which make f2fs_in_warm_node_list become true, >>> that will cause f2fs_bug_on in f2fs_del_fsync_node_entry when >> f2fs_write_end_io called. >> Could you please add below race condition description into commit >> message? >> >> - f2fs_write_end_io >> - f2fs_iget >> - do_read_inode >> - set_cold_node >> recover cold node flag >> - f2fs_in_warm_node_list >> - is_cold_node >> if node is cold, assume we have added >> node to fsync_node_list during writepages() >> - f2fs_del_fsync_node_entry >> - f2fs_bug_on() due to node page >> is not in fsync_node_list > > Ok, will add the commit message. > >> BTW, I'm curious about why we can lose cold flag for non-dir inode? >> any clue to reproduce this bug (I mean losing cold flag)? > > it's a f2fs image with 25600MB > flash this image to device > the device will resize it according to the userdata partition size which is > about 94GB > the device mount the f2fs partition > then hit this f2fs_bug_on > > seems that the cold flag is not been set when mkfs Ah, I guess both mkfs/sload ignores setting cold node flag for non-dir inode, could you please send another patch to fix this issue? > > I think the issue is that > > 1. the node page in the storage is without cold bit > 2. f2fs_disable_checkpoint -> f2fs_gc -> f2fs_get_node_page, this page won't > be set cold flag > 3. f2fs_move_node_page -> __write_node_page to write this page > 4. f2fs_gc -> f2fs_iget -> do_read_inode to read this page and set cold flag Clear enough, thanks for your explanation. :) Thanks, > >>> >>> [ 34.966133] Call trace: >>> [ 34.969902] f2fs_del_fsync_node_entry+0x100/0x108 >>> [ 34.976071] f2fs_write_end_io+0x1e0/0x288 >>> [ 34.981539] bio_endio+0x248/0x270 >>> [ 34.986289] blk_update_request+0x2b0/0x4d8 >>> [ 34.991841] scsi_end_request+0x40/0x440 >>> [ 34.997126] scsi_io_completion+0xa4/0x748 >>> [ 35.002593] scsi_finish_command+0xdc/0x110 >>> [ 35.008143] scsi_softirq_done+0x118/0x150 >>> [ 35.013610] blk_done_softirq+0x8c/0xe8 >>> [ 35.018811] __do_softirq+0x2e8/0x578 >>> [ 35.023828] irq_exit+0xfc/0x120 >>> [ 35.028398] handle_IPI+0x1d8/0x330 >>> [ 35.033233] gic_handle_irq+0x110/0x1d4 >>> [ 35.038433] el1_irq+0xb4/0x130 >>> [ 35.042917] kmem_cache_alloc+0x3f0/0x418 >>> [ 35.048288] radix_tree_node_alloc+0x50/0xf8 >>> [ 35.053933] __radix_tree_create+0xf8/0x188 >>> [ 35.059484] __radix_tree_insert+0x3c/0x128 >>> [ 35.065035] add_gc_inode+0x90/0x118 >>> [ 35.069967] f2fs_gc+0x1b80/0x2d70 >>> [ 35.074718] f2fs_disable_checkpoint+0x94/0x1d0 >>> [ 35.080621] f2fs_fill_super+0x10c4/0x1b88 >>> [ 35.086088] mount_bdev+0x194/0x1e0 >>> [ 35.090923] f2fs_mount+0x40/0x50 >>> [ 35.095589] mount_fs+0xb4/0x190 >>> [ 35.100159] vfs_kern_mount+0x80/0x1d8 >>> [ 35.105260] do_mount+0x478/0xf18 >>> [ 35.109926] ksys_mount+0x90/0xd0 >>> [ 35.114592] __arm64_sys_mount+0x24/0x38 >>> >>> Signed-off-by: Wuyun Zhao >> >> Reviewed-by: Chao Yu >> >> Thanks, >> >>> --- >>> fs/f2fs/inode.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c >>> index be6ac33..0df5c8c 100644 >>> --- a/fs/f2fs/inode.c >>> +++ b/fs/f2fs/inode.c >>> @@ -402,6 +402,7 @@ static int do_read_inode(struct inode *inode) >>> >>> /* try to recover cold bit for non-dir inode */ >>> if (!S_ISDIR(inode->i_mode) && !is_cold_node(node_page)) { >>> + f2fs_wait_on_page_writeback(node_page, NODE, true, true); >>> set_cold_node(node_page, false); >>> set_page_dirty(node_page); >>> } >>> > > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel