From: Chao Yu <chao@kernel.org>
To: Daniel Rosenberg <drosen@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-f2fs-devel@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups
Date: Sun, 28 Jul 2019 08:55:30 +0800 [thread overview]
Message-ID: <9362e4ed-2be8-39f5-b4d9-9c86e37ab993@kernel.org> (raw)
In-Reply-To: <20190723230529.251659-4-drosen@google.com>
On 2019-7-24 7:05, Daniel Rosenberg via Linux-f2fs-devel wrote:
> /* Flags that are appropriate for regular files (all but dir-specific ones). */
> #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL))
We missed to add F2FS_CASEFOLD_FL here to exclude it in F2FS_REG_FLMASK.
> @@ -1660,7 +1660,16 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> return -EPERM;
>
> oldflags = fi->i_flags;
> + if ((iflags ^ oldflags) & F2FS_CASEFOLD_FL) {
> + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode)))
> + return -EOPNOTSUPP;
> +
> + if (!S_ISDIR(inode->i_mode))
> + return -ENOTDIR;
>
> + if (!f2fs_empty_dir(inode))
> + return -ENOTEMPTY;
> + }
I applied the patches based on last Jaegeuk's dev branch, it seems we needs to
adjust above code a bit. Otherwise it looks good to me.
BTW, it looks the patchset works fine with generic/556 testcase.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-07-28 0:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 23:05 [f2fs-dev] [PATCH v4 0/3] Casefolding in F2FS Daniel Rosenberg via Linux-f2fs-devel
2019-07-23 23:05 ` [f2fs-dev] [PATCH v4 1/3] fs: Reserve flag for casefolding Daniel Rosenberg via Linux-f2fs-devel
2019-07-28 0:36 ` Chao Yu
2019-07-23 23:05 ` [f2fs-dev] [PATCH v4 2/3] f2fs: include charset encoding information in the superblock Daniel Rosenberg via Linux-f2fs-devel
2019-07-28 0:45 ` Chao Yu
2019-07-23 23:05 ` [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups Daniel Rosenberg via Linux-f2fs-devel
2019-07-28 0:55 ` Chao Yu [this message]
2019-07-29 6:27 ` Jaegeuk Kim
2019-07-29 7:22 ` Chao Yu
2019-07-29 14:57 ` Chao Yu
2019-07-31 17:57 ` Nathan Chancellor
2019-08-01 1:11 ` Chao Yu
2019-08-01 4:05 ` Jaegeuk Kim
2019-08-21 13:15 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9362e4ed-2be8-39f5-b4d9-9c86e37ab993@kernel.org \
--to=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).