From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6FAC28CBC for ; Thu, 7 May 2020 02:49:10 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC37A20736 for ; Thu, 7 May 2020 02:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="UR6t7h93"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="GTUuqvFl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC37A20736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jWWaz-0001xh-H3; Thu, 07 May 2020 02:49:09 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWWax-0001xQ-MO for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2020 02:49:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VNwzwJtzAfyUnic1uoeJGT2pMVjkMdCq8OB+iUIx/jc=; b=UR6t7h93D2XMNBC2mBT0vekj9j oa1OXri34phW1cn9eQhzQ3ci40gZOa+nEk3YnZ9cHTnUUrBy413cpqoSiSf54bLByxSykHXxln16K oWxSRqtsEh/dqplXc4ugwjgmkg1KrEvWFlT/EVrEVLUB/FdwhAa2ds/VRuMsQ/nLiIJY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VNwzwJtzAfyUnic1uoeJGT2pMVjkMdCq8OB+iUIx/jc=; b=GTUuqvFlema7s2OAgp/rtItJmE 29oTLs8GtBqaON2pXapkXAKZ/mwkUNCTeofJ14f7N9MzulKcpRtrroHoVB/JF3RJ3xhPJHFqGLFw/ Lr2mYzw41XCOnNHVwovzsNyBbIfuNxwmsoeu7OYNs/9hMJ0YQnN5YB2MRPrO5P9R3RHU=; Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jWWau-00AbX2-1g for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2020 02:49:07 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1DE0E82E181631CA2E78; Thu, 7 May 2020 10:48:50 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 7 May 2020 10:48:48 +0800 To: Jaegeuk Kim References: <20200504143039.155644-1-jaegeuk@kernel.org> <7177aab9-630e-e077-7005-0023c93134b3@kernel.org> <20200505230559.GA203407@google.com> <9aaeac5e-4511-5c81-653c-23a85b3c335a@huawei.com> <20200506145608.GD107238@google.com> From: Chao Yu Message-ID: <96140ec8-0fa9-9e4d-4459-1f26737865bf@huawei.com> Date: Thu, 7 May 2020 10:48:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200506145608.GD107238@google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jWWau-00AbX2-1g Subject: Re: [f2fs-dev] [PATCH] f2fs: change maximum zstd compression buffer size X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/5/6 22:56, Jaegeuk Kim wrote: > On 05/06, Chao Yu wrote: >> On 2020/5/6 7:05, Jaegeuk Kim wrote: >>> On 05/05, Chao Yu wrote: >>>> On 2020-5-4 22:30, Jaegeuk Kim wrote: >>>>> From: Daeho Jeong >>>>> >>>>> Current zstd compression buffer size is one page and header size less >>>>> than cluster size. By this, zstd compression always succeeds even if >>>>> the real compression data is failed to fit into the buffer size, and >>>>> eventually reading the cluster returns I/O error with the corrupted >>>>> compression data. >>>> >>>> What's the root cause of this issue? I didn't get it. >>>> >>>>> >>>>> Signed-off-by: Daeho Jeong >>>>> --- >>>>> fs/f2fs/compress.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c >>>>> index 4c7eaeee52336..a9fa8049b295f 100644 >>>>> --- a/fs/f2fs/compress.c >>>>> +++ b/fs/f2fs/compress.c >>>>> @@ -313,7 +313,7 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc) >>>>> cc->private = workspace; >>>>> cc->private2 = stream; >>>>> >>>>> - cc->clen = cc->rlen - PAGE_SIZE - COMPRESS_HEADER_SIZE; >>>>> + cc->clen = ZSTD_compressBound(PAGE_SIZE << cc->log_cluster_size); >>>> >>>> In my machine, the value is 66572 which is much larger than size of dst >>>> buffer, so, in where we can tell the real size of dst buffer to zstd >>>> compressor? Otherwise, if compressed data size is larger than dst buffer >>>> size, when we flush compressed data into dst buffer, we may suffer overflow. >>> >>> Could you give it a try compress_log_size=2 and check decompression works? >> >> I tried some samples before submitting the patch, did you encounter app's data >> corruption when using zstd algorithm? If so, let me check this issue. > > Daeho reported: > 1. cp -a src_file comp_dir/dst_file (comp_dir is a directory for compression) > 2. sync comp_dir/dst_file > 3. echo 3 > /proc/sys/vm/drop_caches > 4. cat comp_dir/dst_file > dump (it returns I/O error depending on the file). Let me check this issue. Thanks, > >> >> Thanks, >> >>> >>>> >>>>> return 0; >>>>> } >>>>> >>>>> @@ -330,7 +330,7 @@ static int zstd_compress_pages(struct compress_ctx *cc) >>>>> ZSTD_inBuffer inbuf; >>>>> ZSTD_outBuffer outbuf; >>>>> int src_size = cc->rlen; >>>>> - int dst_size = src_size - PAGE_SIZE - COMPRESS_HEADER_SIZE; >>>>> + int dst_size = cc->clen; >>>>> int ret; >>>>> >>>>> inbuf.pos = 0; >>>>> >>> >>> >>> _______________________________________________ >>> Linux-f2fs-devel mailing list >>> Linux-f2fs-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >>> . >>> > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel