From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC858C433DF for ; Tue, 4 Aug 2020 07:57:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BBC12076E; Tue, 4 Aug 2020 07:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="lNlgAPf+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="OtyV1Veg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BBC12076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k2rpA-0003r0-DT; Tue, 04 Aug 2020 07:57:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2rp9-0003qt-Gb for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2020 07:57:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XO/n5Ec2Am9OILtA4djHqCZ7wXOJ7xhIRmUc8vpyXAM=; b=lNlgAPf+uMnNR7aZ9mzz9UNzQs HoLWYWYYC8H6CUAheW3iJ7RCrGHbRFncj5jTuMa6rbwsvDQz2geSmak9QRXniqo5GPk6XWDQ6uak5 EvdD//9mKdGduH7jS2jCkEKbsmf+dZ+4gAj5zi3MB2nfkjyN40IECuY+MSED38c0sgt8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XO/n5Ec2Am9OILtA4djHqCZ7wXOJ7xhIRmUc8vpyXAM=; b=OtyV1Veg2xMPi/gYz6JSdYukvl 5lTHtqGuva9iCCW3oVbCQIHt35EtaBd5eFGRmhr7vnC+dgOwQQ07nruzm2JamQ0q8rrmycVKhtvs1 tMoWm83r+I4sU8NFnWfbT/kKkLfhnPcjgPFSo1Xdyg+sqOrCcYzyxdZYa9FXu3XljGZI=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k2rp7-002MRy-AN for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2020 07:57:27 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D07BCF8FA70C7A9EB81C; Tue, 4 Aug 2020 15:57:15 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 4 Aug 2020 15:57:13 +0800 To: Jaegeuk Kim References: <20200729070244.584518-1-jaegeuk@kernel.org> <670f35e1-872b-6602-320c-dd73bcb62510@huawei.com> <20200804035439.GA903802@google.com> From: Chao Yu Message-ID: <9a35fddd-2b67-c91e-2b1a-c63a285cd4ab@huawei.com> Date: Tue, 4 Aug 2020 15:57:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200804035439.GA903802@google.com> Content-Language: en-US X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected X-Headers-End: 1k2rp7-002MRy-AN Subject: Re: [f2fs-dev] [PATCH] f2fs: fix deadlock between quota writes and checkpoint X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/8/4 11:54, Jaegeuk Kim wrote: > On 08/04, Chao Yu wrote: >> On 2020/7/29 15:02, Jaegeuk Kim wrote: >>> f2fs_write_data_pages(quota_mapping) >>> __f2fs_write_data_pages f2fs_write_checkpoint >>> * blk_start_plug(&plug); >>> * add bio in write_io[DATA] >>> - block_operations >>> - skip syncing quota by >>> >DEFAULT_RETRY_QUOTA_FLUSH_COUNT >>> - down_write(&sbi->node_write); >> >> f2fs_flush_merged_writes() will be called after block_operations(), why this doesn't >> help? > > Well, I think bio can be added after f2fs_flush_merged_writes() as well. - down_read(node_write) - f2fs_do_write_data_page - f2fs_trylock_op - f2fs_outplace_write_data - f2fs_submit_page_write bio only be added under node_write lock? during f2fs_flush_merged_writes(), node_write should have been held by checkpoint() avoiding quota data writeback & bio submission. > >> >>> - f2fs_write_single_data_page >>> - f2fs_do_write_data_page >>> - f2fs_outplace_write_data >>> - do_write_page >>> - f2fs_allocate_data_block >>> - down_write(node_write) >>> - f2fs_wait_on_all_pages(F2FS_WB_CP_DATA); >>> >>> Signed-off-by: Daeho Jeong >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/checkpoint.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >>> index 8c782d3f324f0..99c8061da55b9 100644 >>> --- a/fs/f2fs/checkpoint.c >>> +++ b/fs/f2fs/checkpoint.c >>> @@ -1269,6 +1269,8 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, int type) >>> if (type == F2FS_DIRTY_META) >>> f2fs_sync_meta_pages(sbi, META, LONG_MAX, >>> FS_CP_META_IO); >>> + else if (type == F2FS_WB_CP_DATA) >>> + f2fs_submit_merged_write(sbi, DATA); >>> io_schedule_timeout(DEFAULT_IO_TIMEOUT); >>> } >>> finish_wait(&sbi->cp_wait, &wait); >>> > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel