From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called
Date: Mon, 17 Feb 2020 10:22:22 +0800 [thread overview]
Message-ID: <9c497f3e-3399-e4a6-f81c-6c4a1f35e5bb@huawei.com> (raw)
In-Reply-To: <20200214185855.217360-3-jaegeuk@kernel.org>
On 2020/2/15 2:58, Jaegeuk Kim wrote:
> FG_GC needs to move entire section more quickly.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index bbf4db3f6bb4..1676eebc8c8b 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1203,7 +1203,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
>
> if (get_valid_blocks(sbi, segno, false) == 0)
> goto freed;
> - if (__is_large_section(sbi) &&
> + if (gc_type == BG_GC && __is_large_section(sbi) &&
> migrated >= sbi->migration_granularity)
I knew migrating one large section is a more efficient way, but this can
increase long-tail latency of f2fs_balance_fs() occasionally, especially in
extreme fragmented space.
Thanks,
> goto skip;
> if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi)))
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-02-17 2:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:58 [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full Jaegeuk Kim
2020-02-14 18:58 ` [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens Jaegeuk Kim
2020-02-17 1:41 ` Chao Yu
2020-02-17 1:43 ` Chao Yu
2020-02-14 18:58 ` [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called Jaegeuk Kim
2020-02-17 2:22 ` Chao Yu [this message]
2020-02-18 23:27 ` Jaegeuk Kim
2020-02-19 3:01 ` Chao Yu
2020-02-19 3:04 ` Jaegeuk Kim
2020-02-19 3:54 ` Chao Yu
2020-02-24 21:53 ` Jaegeuk Kim
2020-02-25 2:24 ` Chao Yu
2020-02-17 1:40 ` [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c497f3e-3399-e4a6-f81c-6c4a1f35e5bb@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).